CVS edit link for manuelBS

We have developed some modules during our projects. So there is a module to force unique content not only compared by exact matching strings but compared using phonem to match even similar nodes over different fields. There are some "helper modules" that will provide nice functions on Forms an Views.
I also will have the possibility to share cool modules, developed in our projects, with the community.
CommentFileSizeAuthor
#11 bs_nice_frontpage.zip2.42 KBmanuelBS
#10 bs_uniquenode.zip10.67 KBmanuelBS
#1 bs_uniquenode.zip8.55 KBmanuelBS

Comments

manuelBS’s picture

manuelBS commented
Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new bs_uniquenode.zip8.55 KB

Please review this module to get a project on drupal.org. It checks nodes for unique content using phonem to match equal strings that only sounds equal but do not match the exact string (like "drupal" and "trupal" does).

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Needs work

Hello, and thank you for applying for a CVS account. I am adding the review tags, and some volunteers will review the code, pointing out what it needs to be changed.

As per requirements, the motivation message should be expanded to contain more features of the proposed project. For themes, it should include also a screenshot of the theme, and (when possible) a link to a working demo site; for modules, it should include also a comparison with the existing solutions.

manuelBS’s picture

manuelBS commented

ok thanks for your first feedback. Where can I edit my motivation for the modul? Simply post it as another comment?

FernandoTapiaRico’s picture

FernandoTapiaRico commented

Yes, to extend the motivation message just post a new comment.

manuelBS’s picture

manuelBS commented

Here is my new Motivation:

The module bs_uniquenode provides an option for each content type and each CCK Field to make sure content is unique regarding one ore more content fields, including title and cck fields. The most important thing is that strings are not only matched exactly (using the operator ==) but using phonem string comparisons (based on sound string-matching) For example "drupal" and "trupal" will match using phonem. This method can be used on any"text"-field.
The setting "Enable override" on each node type lets you decide if content of a node must be unique or if the user can decide if equal nodes can be inserted anyway.
Phonetic comparison needs a special comparison-index. It is created automatically during cron runs. The index is stored in a separate table in the drupal database.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs work » Needs review

Thank you for your reply.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue tags: +Module review

I am adding the review tags.

drupalshrek’s picture

drupalshrek commented
Status: Needs work » Needs review

Hi,

Sounds like a very interesting module. I've taken a first look. Here's the things I've noticed:

The good:
1) Great idea!
2) You clearly know what you're doing
3) t() is used for translation
4) query parameters appear properly escaped
5) query tables appear properly in {}

The work:
1) All modules should ideally have a README.txt (explaining what it does, how to install [usual stuff, but assume yours is the first module the person has ever installed and you won't go far wrong], how to administer it, how to use it etc.). See http://drupal.org/node/161085. In the end, you're submitting it because you want others to use it, so the better documented, the more that is likely to happen. Remember of course that 90% of admins may not be able to read the code at all, but might still want to be able to use it.

2) Install the Coder module and fix the warnings from that (mostly spaces instead of tabs):
Coder found 1 projects, 2 files, 1019 normal warnings
See also:
http://drupal.org/coding-standards
http://drupal.org/node/161085
http://drupal.org/node/1354

3) I think the correct form of the hook comments is with 3rd person singular verb and the function brackets, e.g.:
* Implements hook_cron()

4) The module does not appear to be themeable (I'm not an expert in this domain so I may be wrong). Basically, whenever you generate HTML you are likely to need to wrap the code in themeable way so that themer gurus can do their magic, just like wrapping text in t() allows translators to do their multilingual magic.

For example, code like the following needs to be themeable:

<?php
	foreach ($matchinContentByNid as $nid=>$title)
	{
		if ($error)
			$error .= "<br/>";
			
		$error .= "<a class='new_window' target='_blank' href='/node/$nid'>$title</a>";
	}
?>

Pages on the subject of making code themeable:
http://drupal.org/node/165706
http://api.drupal.org/api/drupal/includes--theme.inc/group/themeable/6

drupalshrek’s picture

drupalshrek commented
Status: Needs review » Needs work
manuelBS’s picture

manuelBS commented
Status: Needs review » Needs work
StatusFileSize
new bs_uniquenode.zip10.67 KB

hi, I have done my work:

- coder module doesn't show any warning
- README.txt added
- made the frontend functions of the module themable
- changed the comments on hook implementations.

I hope this works, if not, let me know i will do my workk again ;-)

manuelBS’s picture

manuelBS commented
StatusFileSize
new bs_nice_frontpage.zip2.42 KB

I dont know if this will work within this issue but here is another module id like to contriubute. I have checked for warnings by coder module and all the other things i did wrong on my first application. If this is too much for one issue, i will create another one for sure.

--- About This Module --- (more information in readme .tx file)
This module redirects the page /node to a custom page. Even in many big Drupal projects the page /node is often ignored by content and theming. In most cases the front page of drupal in "website settings" is changed from the default /node to a custom page. But the problem is : The page /node will exists and may display many nodes (in many cases even test nodes!!). You could set all nodes to not "display on frontpage" or simply active this tiny module. But the you will see the default page "Welcome to your new drupal website"
If a visitor of your page visits the page /node, he will either be redirected to your real frontpage entered in "website settings" or you can enter a custom destination for the redirect.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs work » Fixed

I am approving the application for the first module.

Welcome on board!

manuelBS’s picture

manuelBS commented

Thanks! Feels good to be on board!

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Assigned: Unassigned » avpaderno

Status: Fixed » Closed (fixed)
Issue tags: -Module review

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Module review

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Component: Miscellaneous » new project application
Issue summary: View changes
Status: Closed (fixed) » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.