Directly populate spool in database, avoid php memory limit exhaust

Here's the code I'm testing. Works on my development server. Haven't yet tested on the live server with thousands of subscribers. Would like you to review before I do that.

Index: simplenews.module                                                                                         
===================================================================
--- simplenews.module   (revision 2820)                                                                          
+++ simplenews.module   (working copy)                                                                           
@@ -1415,11 +1415,11 @@
                                                                                                                 
                                                                                                                 
     if (empty($accounts)) {                                                                                     
-      // No accounts specified. Get email address of all accounts subscribed to this newsletter.                
-      $result = db_query('SELECT s.mail FROM {simplenews_subscriptions} s INNER JOIN {simplenews_snid_tid} t ON s.snid = t.snid WHERE s.activated = %d AND t.tid = %d', 1, $node_data['tid']);                                  
-      while ($account = db_fetch_object($result)) {                                                             
-        $mails[] = array('mail' => $account->mail);                                                             
-      }                                                                                                         
+      // No accounts specified.  Write all active subscriber addresses to mail spool.                           
+      db_query("INSERT INTO {simplenews_mail_spool} (mail, nid, vid, tid, status, timestamp) SELECT s.mail, %d, %d, t.tid, %d, %d FROM {simplenews_subscriptions} s INNER JOIN {simplenews_snid_tid} t ON s.snid = t.snid WHERE s.activated = 1 AND t.tid = %d",                                                                                
+        $node->nid, $node->vid,                                                                                 
+        SIMPLENEWS_SPOOL_PENDING, time(),                                                                       
+        $node->simplenews['tid']);                                                                              
     }                                                                                                           
     else {                                                                                                      
       // Get email address of specified accounts.                                                               

I can't answer the postgres question. Not sure, but I don't think mysql created this syntax.

So, I have one site currenly using simplenews, and I don't want to upgrade to the 2.x branch unless the upgrade path is seemless and it is reliable. How far along is 2.x and when do you recommend people upgrade?

The code you added for t.status does not need to be in the 1.x branch, correct? My database does not have that column.

Thanks, -Dave