Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.After successfully installing BUEditor module, here's what I get:
This string seems awkward and misleading to me. While it might be true on modules such as Views which are "packages" of modules, I would argue that the vast majority of modules people download are not like this.
Furthermore, clicking on that link just takes me to the top of admin/modules, and doesn't jump me down to the row with "BUEditor" in it as one might expect from the text.
So we should either:
1. Slightly re-word the sentence and behaviour of the link.
2. Change the link to something like "Enable your new module(s)."
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | system.updater.patch | 448 bytes | rschwab |
| #5 | system.updater.patch | 791 bytes | rschwab |
Comments
Comment #1
Scott J CreditAttribution: Scott J commentedIsn't the wording trying to tell you which group to look in, for your new module? When you have lots of modules installed, it is a problem in D6 just to find your new module so that it can be turned on.
Comment #2
EvanDonovan CreditAttribution: EvanDonovan commented@webchick: Is BUEditor in a module group called BUEditor?
Could be either "Enable newly added modules" or "Enable newly added modules in the BUEditor group".
Comment #3
EvanDonovan CreditAttribution: EvanDonovan commented(Well, except that the latter option wouldn't be tremendously clear to people who hadn't used Drupal before and didn't know what a module group was. Probably "Enable newly added modules" is best.)
Comment #4
EvanDonovan CreditAttribution: EvanDonovan commentedAfter I tried downloading Feeds module tonight, I am sold on the need for this change.
I changed the title just in case people are thinking it's a BUEditor specific problem.
Comment #5
rschwab CreditAttribution: rschwab commentedPosted here per dww and Evans suggestions. Note that this patch also changes the awkward theme install messaging. New themes are already enabled after install, so it now suggests editing the settings rather than enabling.
Comment #6
rschwab CreditAttribution: rschwab commentedAlthough for theme it would be best to go to admin/appearance/settings/theme_name - I didn't add that because I wasn't sure how to get the machine name for the theme in there.
Comment #7
EvanDonovan CreditAttribution: EvanDonovan commentedI would say the module text is RTBC.
I think this is an improvement for the theme text, but it's still not ideal.
I think that going to admin/appearance/settings/theme_name would actually be incorrect, since you would ordinarily want to enable the theme first, and that's on the main page.
The problem is that the link's current text suggests that clicking it will set the theme to be default, which is not the case. I think this text may be the best we can get.
Comment #8
rschwab CreditAttribution: rschwab commented"you would ordinarily want to enable the theme first, and that's on the main page."
I agree, except from what I can tell the update manager automatically enables the theme.
It seems to me the two possible next steps people would want to take is to:
- Edit the theme settings (at: /admin/appearance/settings/theme_name)
- Set the theme as default (at: /admin/appearance/default?token=not_sure_what&theme=theme_name)
Both of which I didn't have time to look into how to do last night. I'm guessing the token is a session token? I'll take another look tonight.
Comment #9
EvanDonovan CreditAttribution: EvanDonovan commentedAh, I think you're right about it updating the theme, but it doesn't set the theme as default.
I don't know if it would be possible to generate the token for the second URL that you referenced.
Anyway, to address that would be expanding the scope of the patch too far, I think, relative to what webchick's original reported issue was. Maybe we should confine this to just the first change, then it could quickly be marked RTBC as fixing webchick's initial issue.
The theme link text could be fixed, if necessary, as a separate issue.
Comment #10
rschwab CreditAttribution: rschwab commentedOk, narrowing down the patch in #5, and created #975134: Improve links for steps after installing new theme
Comment #11
dww#10 is an improvement. It's text only and the patch follows our standards. RTBC. Thanks, rschwab!
Comment #12
Dries CreditAttribution: Dries commentedCommitted to CVS HEAD. Thanks.
Comment #14
robokev CreditAttribution: robokev commentedFYI, I was confused by the wording "Enable newly added modules" because it made me think that clicking on the link would enable the newly added modules. I always wondered why I had to enable the modules twice.
I now realize that the link only takes you to the page where you can enable the modules, but perhaps the wording might be clearer for the benefit of new users. For example: "Enable newly added modules on the Modules page" or "Enable newly added modules (on the Modules page)"