NodeLoadMultipleUnitTest rely on the fact that traditionally the first created node has nid = 1, the second nid = 2, etc. This doesn't hold true in a lot of scenarios, especially on MySQL cluster setups.

CommentFileSizeAuthor
#1 936412-node-load-multiple-increment.patch2.77 KBdamien tournoud

Comments

damien tournoud’s picture

damien tournoud commented
Status: Active » Needs review
StatusFileSize
new 936412-node-load-multiple-increment.patch2.77 KB
gdd’s picture

gdd
he/him
Primary language English
Location Portland, OR
commented
Status: Needs review » Reviewed & tested by the community

Nice catch, applies, looks good pending bot.

damien tournoud’s picture

damien tournoud commented
Title: NodeLoadMultipleUnitTest rely on autoincrement details » NodeLoadMultipleUnitTest relies on autoincrement details
Status: Reviewed & tested by the community » Needs review
moshe weitzman’s picture

moshe weitzman commented

you didn't write it, but the comment 'Nodes 1, 2 and 3 will be loaded.' omits node4 which is also loaded.

pwolanin queued 1: 936412-node-load-multiple-increment.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 1: 936412-node-load-multiple-increment.patch, failed testing.

Status: Needs work » Closed (outdated)

Automatically closed because Drupal 7 security and bugfix support has ended as of 5 January 2025. If the issue verifiably applies to later versions, please reopen with details and update the version.