'#' to '%23' replacement works in url to file display but not generic file display

We have file names containing the '#' character. When node view is set to 'url to file' display, '#' is properly encoded as '#23', but when node view is set to 'generic file display' it is not properly encoded, resulting in page not found error.

Fixed by adding

$url = file_create_url($path);
/* '#' fix */ $url = str_replace('#', '%23', $url);
$icon = theme('filefield_icon', $file);

to line 125 in filefield_formatter.inc