Regression: Installer defaults country to 'Afghanistan' not '- None -'

The best way would be to add #empty_value => '' to this element (assuming I understand the other issue correctly).

Indeed.

Indeed.

Looks good. Tested #5, default country is back to "- None -".

+++ includes/install.core.inc
@@ -1759,6 +1759,7 @@ function _install_configure_form($form, &$form_state, &$install_state) {
     '#title' => t('Default country'),
+    '#empty_value' => '',
     '#default_value' => variable_get('site_default_country', NULL),
     '#options' => $countries,
     '#description' => st('Select the default country for the site.'),

Yes, that's correct, for both.

BTW, can someone explain me WTF this Default country is? It's only ever set in the installer, only get in System regional settings, and the description does not explain what it "could" be good for.

Powered by Dreditor.

That said, that's a different issue.

RTBC if it comes back green.

sun wrote:

BTW, can someone explain me WTF this Default country is? It's only ever set in the installer, only get in System regional settings, and the description does not explain what it "could" be good for.

It seems to have been introduced for D7 core by #333156: Add ability to configure site default country. They said:

This patch is just a first step towards supporting country specific date and number formats. It doesn't provide any per-country functionality (yet), but the idea is that in the future, both core and contrib modules can add country-specific features without each module defining their own method to configure the default country for the site.

This country setting (for time zones, languages, date formats, etc.) is also provided for D6 by the Site Country module, used by Country code. Both seem to be experimental modules.

It's green now...

Yay!! Committed to HEAD!

(Sorry, Damien, I was too eager to commit this and missed your name on the commit message. I'll add you twice next time.)