I'm using filedepot in OpenAtrium (with the Filedepot feature.) That itself doesn't belong to this project, but I noticed that the currently broken links with the feature can be fixed by creating the URLs to files for notification emails with url() instead of hard coding them. This is probably because Organic Groups hooks into url() and modifies the address to include the group.
As I think using url() is also the Right Way to do it, I'm attaching a patch that I hope will be committed to Filedepot. This makes the URL's work with Organic Groups and also makes them more pretty whenever clean URLs is enabled.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | filedepot-url-functions-2.patch | 11.76 KB | zeip |
| #1 | filedepot-url-functions.patch | 11.72 KB | zeip |
| filedepot-use_url_for_links.patch | 1.68 KB | zeip |
Comments
Comment #1
zeip commentedAttached is a patch that supersedes the previous patch. This one contains a few additional similar url() changes, PLUS I've removed quite a lot of unnecessary global's in different files. Also fixed one typo (Fildepot vs. Filedepot) in the broadcast email. I hope someone would review these changes and, if they're ok, commit them to Filedepot.
Comment #2
cnamade commentedI have this message when i load file in depot folder
mail() [function.mail]: SMTP server response: 501 5.1.3 Invalid address in C:\wamp\www\drupal-6.19-prod\includes\mail.inc on line 194.
my adress mail il correct .
is there a issue for this problems ?
Comment #3
blainelang commented@ZeiP: I was not able to apply your 2nd patch - it fails on the lib-ajaxserver.php changes.
Comment #4
blainelang commented@cnamade: Don't believe anyone has reported this error as far as I know there have not been email sending issues.
Comment #5
cnamade commentedhow to fix my problem, i'm a newbies.
Comment #6
zeip commentedblainelang, the file has apparently changed, I was able to apply the patch with command ”patch -p0 < file.patch”, but offset on lib-ajaxserver.php was 20 lines.
Attaching a fixed patch against current CVS.
Comment #7
zeip commentedcnamade, please post a new issue instead of using this one. You can use the form at http://drupal.org/node/add/project-issue/filedepot .
Comment #8
blainelang commentedThanks ZeiP, the patch applied cleanly and is now committed to CVS.