Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
According to RFC5322 (which obsoletes RFC2822), Section 3.6.3 (http://tools.ietf.org/html/rfc5322#section-3.6.3), the correct format for destination address fields are "To:", "Cc:", and "Bcc:".
The PHPMailer module does not correctly match those header fields when processing e-mails, and therefore, incorrectly puts recipients specified in those fields into a "CustomHeader" field, and never sends the message to those recipients.
The attached patches corrects that behavior for the 6.x-2.x and 6.x-3.x versions.
Comment | File | Size | Author |
---|---|---|---|
cc_and_bcc_case-6.x-3.x.patch | 3.19 KB | oadaeh | |
cc_and_bcc_case-6.x-2.x.patch | 3.19 KB | oadaeh | |
Comments
Comment #1
sunThis looks very very correct. No idea why the existing code is using all-uppercase keys. I've grepped through Drupal core and couldn't find a single instance of
/'cc'/i
anywhere, so all that prevents me from committing this patch is that I do not know whether any other code in Drupal is using those all-uppercase tags (in which case we'd have to care for both formats).However, since there is not a single instance of 'Cc' in core, this can also only mean that we're passing mail header values directly to the responsible mail system/engine, which in turn means that we should follow the RFC here.
Marking RTBC to see whether @smk-ka has any objections.
Comment #2
sunMimeMail is also using the properly capitalized keys:
so...
Thanks for reporting, reviewing, and testing! Committed to 7.x-3.x and 6.x-3.x.
A new development snapshot will be available within the next 12 hours. This improvement will be available in the next official release.
Comment #4
bendiy CreditAttribution: bendiy commentedCan't BCC without this patch. It hasn't made it into the recommended releases yet, just dev.
Comment #5
chinita7 CreditAttribution: chinita7 commentedI patched it to 3.1 version and it works. Thanks @oadaeh. I have tried also the latest dev version but didn't send Bcc without the patch.