I'm getting the following error:

Notice: Undefined index: path in admin_menu_link_build() (line 53 of sites/all/modules/contrib/admin_menu/admin_menu.inc).

It turns out all of these come from the Nodewords module v6.x-1.11. An example menu object that fails is the following:

... (Array, 7 elements)
    title (String, 16 characters ) General settings
    access arguments (Array, 1 element)
        0 (String, 20 characters ) administer meta tags
    type (Integer) 136
    weight (Integer) -1
    file (String, 25 characters ) nodewords_admin.admin.inc
    module (String, 10 characters ) admin_menu
    menu_name (String, 10 characters ) admin_menu

While there's clearly a bug in Nodewords, I think admin_menu should be smart enough to properly handle this.

CommentFileSizeAuthor
#16 undefined_index-927018-16.patch513 byteslazysoundsystem
#8 admin_menu-927018-1-6.x-1.x.patch521 bytesmikeytown2
#1 admin_menu-n927018.patch643 bytesdamienmckenna

Comments

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review
StatusFileSize
new admin_menu-n927018.patch643 bytes

Here's a patch to do a quick check to see if the variable exists before using it.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Closed (won't fix)

Thanks for the patch! However, there's no further development on 1.x, because it has been superseded by 3.x a long time ago.

7.x-3.x works 99% flawlessly, 6.x-3.x still has some problems that are hard to fix, but we should concentrate on those instead.

Sorry. I really enjoy seeing you almost everywhere on d.o with useful stuff and love your contributions!

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

I'll swap over to v6.x-3.x then. Thanks for the response, and kind words :)

john franklin’s picture

john franklin commented

It's been more than a year since the last alpha release of 6.x-3.0. Are there plans for a full release (or even a "recommended" beta) in the near future? If not, could this patch be applied to 1.6 and a 1.6.1 release pushed out, please?

Stalski’s picture

Stalski commented

The same issue appears with the rules module not having a path.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Closed (won't fix) » Reviewed & tested by the community

Seeing as we've had two recent releases of 6.x, I'm reopening this for inclusion in the next release.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Reviewed & tested by the community » Needs review

I accidentally RBTC'd my own patch. Sorry.

mikeytown2’s picture

mikeytown2 commented
Title: Undefined index: path in admin_menu_link_build() » Undefined index: path/title in admin_menu_link_build()
Version: 6.x-1.6 » 6.x-1.x-dev
StatusFileSize
new admin_menu-927018-1-6.x-1.x.patch521 bytes

got the error on title as well

drupizzle’s picture

drupizzle commented

#8 worked! Thanks! Running pressflow 6, mercury, varnish, memcache.

mikeytown2’s picture

mikeytown2 commented
Status: Needs review » Reviewed & tested by the community
asb’s picture

asb commented

The patch from #8 applies cleanly against admin_menu 6.x-1.8 and seems to fix the issue (running Pressflow 6.22, Memcache and APC, in case that matters).

fluxsauce’s picture

fluxsauce commented

Thank you to #8 with Pressflow 6.22.104, no memcache, apc, varnish, or memcache.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Reviewed & tested by the community » Fixed

Thanks for reporting, reviewing, and testing! Committed to 6.x-1.x.

A new development snapshot will be available within the next 12 hours. This improvement will be available in the next official release (if any).

fluxsauce’s picture

fluxsauce commented

Excellent, thanks for your assistance!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

lazysoundsystem’s picture

lazysoundsystem commented
StatusFileSize
new undefined_index-927018-16.patch513 bytes

Until the next official release of 6.x-1.x (if any), here is exactly the same patch as comment 8, but made with 'git diff --no-prefix' for compatibility with drush_make.

christowm’s picture

christowm commented
Version: 6.x-1.x-dev » 6.x-1.8

The same type of message comes up with 6.x-1.8.

Notice: Undefined index: path in admin_menu_link_build() (line 66 of /home/quickstart/websites/demo.dev/sites/all/modules/admin_menu/admin_menu.inc).

The patch works fine for the current 6.x-1.8 release as well.