Suppose I have a makefile like:

core = 6.x
projects[views] = 2.11
projects[strongarm] = 2.0

And it is included by another makefile like this:

includes[] = http://example.com/foo.make

; ... other stuff

While the second makefile can override properties of the first, there is no way to remove a particular entry of projects[] without redefining the projects array entirely from the start.

This patch allows for the following to be valid:

includes[] = http://example.com/foo.make

projects[views] = FALSE

This is valid .info file syntax (sets $projects['views'] = FALSE) and would mean to omit / unset this entry altogether. It can of course be overridden by later lines or another includer.

CommentFileSizeAuthor
#5 924630.2.patch5.32 KByhahn
#1 924630.1.patch1.19 KByhahn

Comments

yhahn’s picture

StatusFileSize
new1.19 KB
yhahn’s picture

Status: Active » Needs review
dmitrig01’s picture

Let's document this.

dmitrig01’s picture

Status: Needs review » Needs work
yhahn’s picture

Status: Needs work » Needs review
StatusFileSize
new5.32 KB

Word. Attached patch updates docs and robustifies our includes tests to test property overrides as well as removal of projects.

dmitrig01’s picture

Status: Needs review » Fixed

Looks good - thaanks

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.