Closed (fixed)
Project:
OpenSearch feed
Version:
6.x-1.3
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
27 Sep 2010 at 01:35 UTC
Updated:
26 Nov 2010 at 21:50 UTC
Jump to comment: Most recent
Comments
Comment #1
agharbeia commentedI confirm this error.
The function definition in opensearch.module is "opensearch_check_plain", sans the initial underscore, as the name.
Patching this module by changing the function definition resolves the issue.
Comment #2
bennos commentedremoving the underscore solves the issue.
changing the status.
Comment #3
Anonymous (not verified) commentedComment #4
Anonymous (not verified) commentedI changed the code, and committed in the development snapshot; I also created a new release (version 6.x-1.4-beta1).
Comment #6
lord_atreide commentedThe current recomended code in Drupal Modules is the wrong 6.x-1.3 which is unusable. I suggest to backport changes in 6.x-1.4-beta1 or consider this version as the stable one.
The current behaviour of this module is broken as is.
Comment #7
wiifmI fully agree with @lord_atreide - having downloaded and then turn on the module (version 1.3 'stable') to be confronted with a fundamental PHP error, is just plain wrong.
The 1.4 beta1 release needs to be on the modules homepage as stable (why not call it 1.4?)
Comment #8
avpadernoIt is not possible to port the fix that is present in version 6.x-1.4-beta1 to a pre-existing version; this is how Drupal release system works.
Comment #9
wiifm@kiamlaluno but you can release a new stable version so that users are not confronted with a PHP error!
Comment #10
dave reid@wiifm: You can download it yourself at http://drupal.org/node/925690. Because the 6.x-1.4 version is still beta, our release system doesn't show it on the project frontpage.