Closed (fixed)
Project:
Chaos Tool Suite (ctools)
Version:
6.x-1.x-dev
Component:
Code
Priority:
Minor
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
25 Sep 2010 at 12:41 UTC
Updated:
29 Oct 2010 at 22:20 UTC
Jump to comment: Most recent file
Comments
Comment #1
eugenmayer commentedsurely a minor
Comment #2
dawehner.
Comment #3
neclimdulI'm not really sure about the NULL logic. Would the attached patch work as well? The logic seems a little more straightforward.
This definitely needs some review though, I wrote this off the cuff without testing it.
Comment #4
voxpelli commentedI would propose a patch like the one I attach instead.
Avoids possible conflicts between dir-names and file-names and is a lot more compact.
Comment #5
voxpelli commentedReroll that avoids a // path on empty $dir.
Comment #6
merlinofchaos commentedCommitted #5 to all branches.