Closed (fixed)
Project:
Microcart Block
Version:
6.x-1.1
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
25 Sep 2010 at 00:50 UTC
Updated:
15 Feb 2011 at 06:30 UTC
Jump to comment: Most recent file
Comments
Comment #1
wjaspers commentedThe block not appearing when the setting is unchecked is a result of it not checking the setting on display.
Attached is a patch to fix it. I also clarified the the terminology, and ensured the setting explanation is translated.
Comment #2
wjaspers commentedArghh ... forgot to update the tracker again. I love the new Drupal site; but it's harder than ever to notice the tracker block.
Comment #3
gregoiresan commentedHi,
did you find out for your currency issue ? I didn't use the patch as I couldn't clearly see if it was inside... it seems that the hiding block issue is the only one fixed, isn't it ?
Comment #4
wjaspers commentedNo, I didn't get around to the currency issue. I need to read up on the ubercart core to correctly load the currency.
I did, however, fix the block appearance problem.
Comment #5
wjaspers commentedHere's a fix for the currency issue. Fortunately, ubercart supplies a really simple hook for formatting the price
uc_currency_formatand automatically deals with finding your settings.For the patch reviewer:
There are TWO patches to be reviewed on this thread.
The first fixes block displays and the second fixes the currency formatting problem.
Comment #6
gregoiresan commentedWhat a quick answer, thanx !
I'll test it and tell you how it goes:)
Comment #7
summit commentedHi,
This patch #5 is working great! Thanks for posting.
Don't know why but on Ubercart 2.4 I had to add the uc_currency_format function: http://api.ubercart.org/api/function/uc_currency_format. It was //out on my install.
greetings, Martijn
Comment #8
summit commentedWorking great with patch #1 and #5! Greetings, Martijn
Comment #9
rich.yumul commentedpatches were committed to CVS, will be included in next release. :)