[comment:name] duplicates [comment:author], and the latter should use format_username()

+++ modules/comment/comment.tokens.inc	21 Nov 2010 22:03:45 -0000
@@ -87,7 +83,7 @@ function comment_token_info() {
+    'description' => t("The author of the comment."),

Should use single quotes.

+++ modules/comment/comment.tokens.inc	21 Nov 2010 22:03:45 -0000
@@ -131,19 +127,21 @@ function comment_tokens($type, $tokens, 
+        case 'author':
+          $name = $comment->name;
+          if (!empty($comment->uid) || !drupal_strlen($comment->name)) {
+            $account = user_load($comment->uid);
+            $name = format_username($account);
+          }

The user_load() should only happen if uid > 0. For anonymous users, it's 100% overhead.

Powered by Dreditor.

I tried applying the patch and it did not resolve an issue I'm experiencing with my view of Recent Comments. The view is set up like this:

(Content) Content: Title (§ )
Comment: Updated date
Comment: Title
Comment: Author (by )
Comment: Comment
Global: Custom text

And the result is that the Author fields are all shown as "Anonymous" even though the authors should be known.

Probably the recent comments issue is a related problem in the views module, I made a separate bug report there: http://drupal.org/node/1210338

Er... nevermind. I hadn't actually imported the 'name' fields. Sorry for the disruption.

Rerolled for 8.x

#4: 920056-tokens-format-username-D7.patch queued for re-testing.

format_username() renamed to user_format_name()

This is my attempt at the reroll process.

The patch in #14 failed to apply and looking at the code it is still applicable. So, I made a new patch. But, I can't attach it because it exceeds the maximum upload size of 3MB. The new patch is 5MB like the others in this issue.

How do I attach it?

Oops, sorry all. I wrote that just before going to bed and clearly wasn't paying attention to what I was reading or what file I uploaded.

I hope to sort that within the week.

Trying again

code changed a lot. also related changes coming in #2028025: Expand CommentInterface to provide methods

Wow, that week became 4 months.

Re-roll for patch from #20.
Found no usecase for format_username as it is now only a wrapper around '$account->getUsername()' which seems to be used in the places where this patch used format_username.

This doesn't do what the issue summary says at all (presumably fixed elsewhere), instead it just fixes a problem mentioned in #4.

Re-roll, fix to use user name
Added test

Green and needs review.
Updated summary

CR https://www.drupal.org/node/2371365

@andypost thanks for the clear issue summary.

Patch worked for me, passed all the comment tests.

looks rtbc to me
@catch noted in #2031901: Remove node tokens from comment.tokens.inc that he's happy for these cleanups to go in now

This issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed a36ff84 and pushed to 8.0.x. Thanks!