See patch.

Files: 
CommentFileSizeAuthor
#13 Add file | drupal7dev.local (mysql).png20.9 KBDave Reid
#12 Add file | drupal7dev.local (mysql).png20.57 KBDave Reid
#11 915352-media-internet-cleanup-providers.patch2.24 KBDave Reid
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 915352-media-internet-cleanup-providers_1.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#10 915352-media-internet-cleanup-providers.patch2.1 KBDave Reid
PASSED: [[SimpleTest]]: [MySQL] 0 pass(es).
[ View ]
#9 915352-media-internet-cleanup-providers.patch1.74 KBDave Reid
PASSED: [[SimpleTest]]: [MySQL] 0 pass(es).
[ View ]
#8 convert-provider-list-to-text-915352-8.patch1.81 KBDevin Carlson
PASSED: [[SimpleTest]]: [MySQL] 0 pass(es).
[ View ]
#4 media-provider-css.915352.4.patch575 bytesJon Pugh
PASSED: [[SimpleTest]]: [MySQL] 11 pass(es).
[ View ]
media-provider-css.patch1.63 KBeffulgentsia
FAILED: [[SimpleTest]]: [MySQL] 159 pass(es), 1 fail(s), and 0 exception(es).
[ View ]

Comments

Status:Needs review» Needs work

The last submitted patch, media-provider-css.patch, failed testing.

effulgentsia’s picture

Status:Needs work» Fixed

Whoa. We have testbot running on this project! When did that happen? I don't think the failure is related to this patch though. I committed the patch, as it's a no-brainer.

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Jon Pugh’s picture

Assigned:Unassigned» Jon Pugh
Status:Closed (fixed)» Needs review
StatusFileSize
new575 bytes
PASSED: [[SimpleTest]]: [MySQL] 11 pass(es).
[ View ]

Those icons drive me batty. Why are they even sprites, anyway? They aren't linked...

Here's a lame patch that crops the images with CSS and goes ahead and adds :hover positioning for these non-links.

If we don't want this, we should just change those images to not be sprites?

gmclelland’s picture

Why don't we get rid of the big provider icons all together and just use fav icons for each provider? We can also show each provider using a vertical accordion. When you click on a provider name it would expand to show the usage examples.

See #1494416: UX - Providers - List Usage Examples

Devin Carlson’s picture

Dave Reid’s picture

I'd rather just use text for the providers at this point. This has been horribly broken for so long.

Devin Carlson’s picture

Version:7.x-1.x-dev» 7.x-2.x-dev
Assigned:Jon Pugh» Devin Carlson
StatusFileSize
new1.81 KB
PASSED: [[SimpleTest]]: [MySQL] 0 pass(es).
[ View ]

A patch to convert the display of providers into an unordered list of provider titles per #7.

I haven't removed 'image' from media_internet.api.php but that could be done if required.

Dave Reid’s picture

StatusFileSize
new1.74 KB
PASSED: [[SimpleTest]]: [MySQL] 0 pass(es).
[ View ]

Here's the code I had locally with a little bit cleaner output and removes the CSS from media.css. If we want to re-add it it should be going in media_internet.css and not the base CSS.

Dave Reid’s picture

StatusFileSize
new2.1 KB
PASSED: [[SimpleTest]]: [MySQL] 0 pass(es).
[ View ]

With the CSS removal.

Dave Reid’s picture

StatusFileSize
new2.24 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 915352-media-internet-cleanup-providers_1.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

With a nice class for each list item so that it can be styled by individual modules.

Dave Reid’s picture

StatusFileSize
new20.57 KB

Here's how it looks with the patch in #11.

Add file | drupal7dev.local (mysql).png

Dave Reid’s picture

StatusFileSize
new20.9 KB

This would also make it possible to do something like this:

.media-internet-providers li.youtube {
  list-style-image: url(/sites/all/modules/media_youtube/images/youtube_16.png);
}

.media-internet-providers li.vimeo {
  list-style-image: url(/sites/all/modules/media_vimeo/images/vimeo_16.png);
}

which would look like:
Add file | drupal7dev.local (mysql).png

Dave Reid’s picture

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.