When admin_menu is enabled, it gets displayed on the Media popup page render. I filed #914786: Best way to disable admin_menu on iframe popups to figure out a long-term solution for this type of problem, but for now adding admin_menu_suppress() fixes the issue.

http://skitch.com/davereid20/dagcg/create-media-localhost

CommentFileSizeAuthor
#1 914834-media-adminmenu-suppress-D7.patch1.92 KBdave reid

Comments

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Active » Needs review
StatusFileSize
new 914834-media-adminmenu-suppress-D7.patch1.92 KB
dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Screenshot of popup after patch: http://skitch.com/davereid20/dagc1/create-media-localhost

Status: Needs review » Needs work

The last submitted patch, 914834-media-adminmenu-suppress-D7.patch, failed testing.

robeano’s picture

robeano commented

This seems reasonable for a temporary fix until #914786 is handled. Committed.

tsvenson’s picture

tsvenson commented

@robeano

This fix causes fatal error when using the WYSIWYG media browser and Admin Menu is not enabled. There is no check to test if Admin Menu is available or not.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Priority: Normal » Critical

Gah, can't believe I didn't add that check.

robeano’s picture

robeano commented

How embarrassing. I committed a check that Admin Menu is enabled before suppressing the extra menu.

robeano’s picture

robeano commented
Status: Needs work » Fixed

Changing issue status to Fixed.

gandhi’s picture

gandhi commented
Status: Fixed » Needs review

#1: 914834-media-adminmenu-suppress-D7.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 914834-media-adminmenu-suppress-D7.patch, failed testing.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

RobW’s picture

RobW commented

Issue title: woah.