Adding presave/postsave hooks to Plupload

This looks great to me!

I'd like to add more parameters to each call, perhaps a $options as an array or something, so that we can send in more data.

My dream is that at /file-plupload we could add parameters like /file-plupload?terms[]=1,5,60?gids[]=99 And then a module would add taxonomy terms 1, 5, 60 and OG could add the group 99. To do that cleanly we should add hooks like you suggest and give them some more data.

I don't think so.

There's the /file-plupload?tids[]=1,2,3 URL. That has the parameters in it.

But the actual URL that gets the files is just "plupload-pernode" without any parameters.

What we need to do is add the tids into the headers

headers
Name/value object with custom headers to add to HTTP requests.

I don't expect your patch to fix all that, but we should at least build these hooks with the ability to handle extra $options.

Just a note that you can use nodeapi to do operations on just plupload added nodes by adding this to the presave op:

        $item = menu_get_item();
        if ($item['path'] == 'plupload-pernode') {
          // do stuff
        }

The approaches above are more clean, but my approach is a workaround until such a feature is implemented.

I'm thinking that with the inclusion of #919482: create ability to assign parameters in the url, implement taxonomy term as an example, we don't need these hooks any longer. Here's an example of how you can achieve what Vordude wants without any hooks. If you're using the included file-plupload page, just link to it like so: 'file-plupload?drupal_pluploaded=1'

If you're calling the plupload_upload_page function within your module, pass it this:

array('drupal_pluploaded' => TRUE);

Now, in nodeapi (prepare and save for your pre and post hooks), you can simply say:

if ($node->pluploaded) {
  // do stuff
}

We can certainly implement hooks if need be, but I think at this point it just is duplicating existing features. Thoughts?

I think more hooks are better than fewer. If we add in the $options that is created in #919482: create ability to assign parameters in the url, implement taxonomy term as an example then I think this patch is ready to go.

Hadn't thought of the sub-module thing - agree. I'll commit #919482: create ability to assign parameters in the url, implement taxonomy term as an example today if you want to reroll your patch.

OK, I'll bite. Here's a re-rolled patch with the options passed in.

Heh, you're right. That'll teach me to create patches when on Nyquil :)

AFAIK, call-time pass by reference is a warning in PHP <= 5.2, but an error in 5.3+.

Have you actually tested the patch? I'd have to code up a dummy hook to test it.

Committed to 6.x dev: #914252 by vordude, greggles, justintime: Adding presave/postsave hooks to Plupload

Forgot to mark as fixed.

subscribing...

brunorios1 - why are you subscribing to an issue that is "closed - fixed."

If it's broken or you need something please say what it is.

sorry, was a mistake...