content_field_instance_read returns an array of fields, not a single field

Fixing it changed a 301 sec revert to 37 (...now to figure out why all content is ending up as overriden >.O :P).

CommentFileSizeAuthor
#4 features.908618-4.patch739 bytesGrayside
correctly_check_instance.patch731 byteshefox

Comments

hefox’s picture

hefox commented
Status: Active » Needs review
Grayside’s picture

Grayside commented

Is the overridden bit a bug in this patch? Shouldn't it be Needs Work then?

hefox’s picture

hefox commented

Nay, the overridden was purely from me being a bit too experimental at times and mentioned as a lolz (cause lots of things overridden + this bug == Slow, slow, slow, features rebuilds).

Grayside’s picture

Grayside commented
StatusFileSize
new features.908618-4.patch739 bytes

Chasing HEAD. Now to test.

Grayside’s picture

Grayside commented
Status: Needs review » Reviewed & tested by the community

Tested and works.

Here are some incoherent instructions on how to test that this patch works as advertised:

Set widget_active=0 in content_node_field_instance for a field. Test that content_clear_type_cache(TRUE); is only fired in content_features_rebuild($module) once, plus once per inactive field. Do this by dropping a strategic dpm() to let you know the name of the field getting a the cache clear. And throw features_revert(array('module_name' => array('content'))); in hook_init() somewhere.

hefox’s picture

hefox commented
Status: Reviewed & tested by the community » Fixed

Commit http://drupalcode.org/project/features.git/commit/c98e1ec

febbraro’s picture

febbraro commented

hefox, do we think this is something that needs to be looked at in D7?

hefox’s picture

hefox commented

I looked into it briefly, but from what I saw, it didn't look to be since fields API is different (when commiting bug fixes ford6 I check the code in d7 to see if it needs to be upported).

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.