There are several issues in review mode that cause destroying of written comments, having to take extra time to differentiate the buttons and overall it isn't very effective communicating its actions. Since I have no actual use for the review mode (I dont write code) here goes scratching my own itch, of killing all ugliness in Drupal.

CommentFileSizeAuthor
#8 2011-01-30_0222.png178.62 KBBojhan
#1 thumb.png141.01 KBBojhan
dr.editor-is-refreshed.png84.71 KBBojhan

Comments

Bojhan’s picture

Bojhan commented
Category: task » bug
Priority: Normal » Major
StatusFileSize
new thumb.png141.01 KB

So..

jacine’s picture

jacine
she/her
Location New York
commented

subscribing :D

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Title: Review mode is ineffective due to ugliness » Redesign patch reviewer
Category: bug » task

In addition to the current proposal, I'd like to merge in at least the major design tweaks of @Jacine's Applification in http://userstyles.org/styles/21102

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

Since I mentioned it before @Bojhan worked on the UI proposal, it's already accounted for, but nevertheless others should also know about #735606: Let the user confirm before canceling

Bojhan’s picture

Bojhan commented

@sun Which major design tweaks?

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

I mainly mean the grey-shaded, modern looking sidebar and buttons in @Jacine's user style.

Those styles, combined with the revised user interface proposal in the OP, should make a really nice redesign.

jacine’s picture

jacine
she/her
Location New York
commented

What is the cog in the OP is going to be for?

Bojhan’s picture

Bojhan commented
StatusFileSize
new 2011-01-30_0222.png178.62 KB

One note.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

Didn't fully understand why or because of what, but http://chopapp.com/ was mentioned as inspiration for Dreditor on Twitter.

robloach’s picture

robloach
he/him
commented

Absolutely love this look. Matches the Blue Cheese design quite nicely... Congrats on the biggups from ChopApp, sun :-) .

markhalliwell’s picture

markhalliwell
Primary language English
commented

Alas, I create an issue after searching for it and then just found this one lol Referencing #1839136: Update patch review CSS.

There were a lot of under the hood parsing changes aside from just styling in mine. If needed, I can close that one and start discussing here?

Bojhan’s picture

Bojhan commented

@Mark Could we pick this up again? I can provide revised designs where needed.

markhalliwell’s picture

markhalliwell
Primary language English
commented

I'd be happy to consider this and agree the container/wrapper needs some work. I'll probably want to get neochief in on this too though.