Closed (fixed)
Project:
Apache Solr Search
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
1 Sep 2010 at 15:24 UTC
Updated:
17 Sep 2010 at 14:40 UTC
The way a search runs now, we call apachesolr_search_execute(), which calls apachesolr_do_query(), and then apachesolr_search_process_response(). Both of those functions take $params as an argument, but apachesolr_do_query has all of the alters() and modifies() and finalizes(), and it is a common case that $params is a different beast by the time apachesolr_search_process_response() comes about. Yet having the right $params is crucial to apachesolr_search_process_response() being able to do its job correctly. Thus, the easiest solution for the time being, without refactoring the whole search flow, is to make &$params a reference into apachesolr_do_query().
| Comment | File | Size | Author |
|---|---|---|---|
| params_by_reference.patch | 874 bytes | robertdouglass |
Comments
Comment #1
robertdouglass commentedComment #2
pwolanin commentedsounds reasonable to me
Comment #3
jpmckinney commentedMarking #875158: Pagination error duplicate (which has same patch).
Comment #4
robertdouglass commented#899560 by robertDouglass: Fixed apachesolr_do_query() has to take $params by reference.
Comment #5
mkalkbrennerBecause #892524: apachesolr_do_query() breaks custom highlighting has been marked as duplicate of this issue I reopened this one to request this fix to be ported to 6.x-1.x.
As long as this issue exists in 6.x-1.x we're not able to release a stable version of Apache Solr Multilingual 6.x-1.0 because we don't have snippets in the search results.
Comment #6
robertdouglass commentedfiexFixed in 6.1 as well.