The attached patch fixes a couple of compatibility issues with PostgreSQL, without hopefully breaking anything in MySQL (but it is untested on MySQL). Specifically, it fixes

1) a query error caused by the use of double quotes instead of single quotes, and
2) an encoding error that would happen when refreshing browscap data.

Please review and, possibly, merge into the next release.

browscap-module.patch978 byteslifepillar
Members fund testing for the Drupal project. Drupal Association Learn more


greggles’s picture

I was unsure about the change with %b to remove the ''. From reading it says that it's correct to use %b without enclosing it in ''.

This looks good to me.

greggles’s picture

Title: PostgreSQL compatibility issues » PostgreSQL compatibility issues in browscap
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.