Add project_issue module's issue_cockpit block to the default dashboard.

Configured with #874790: Configurable blocks

Add to Dashboard links with #874792: Add to homebox links

CommentFileSizeAuthor
#10 898180-10.issue_homebox_block.A.patch3.49 KBdww
#10 898180-10.issue_homebox_block.B.patch5.54 KBdww
#9 project_issue.diff3.33 KBdrumm
#6 homebox.patch39.89 KBdrumm
#4 project_issue.diff2.99 KBdrumm

Comments

drumm’s picture

drumm
he/him
Location NY, US
commented
Issue tags: +drupal.org redesign, +drupal.org redesign dashboard

tag

drumm’s picture

drumm
he/him
Location NY, US
commented
Issue tags: +drupal.org redesign sprint 4
drumm’s picture

drumm
he/him
Location NY, US
commented
Assigned: Unassigned » drumm
drumm’s picture

drumm
he/him
Location NY, US
commented
Project: Drupal.org customizations » Project issue tracking
Version: » 6.x-1.x-dev
Issue tags: +drupal.org redesign project
StatusFileSize
new project_issue.diff2.99 KB

This adds homebox integration so you can an 'Issue Cockpit' block for arbitrary projects on your dashboard. The hooks are being added with #874790: Configurable blocks

dww’s picture

dww
we/he/they
commented
Status: Active » Needs work

A) It's not obvious where/how the nid is actually being saved, nor what project_issue_homebox_block_edit_form() is really about. A comment to that effect would be very helpful, since I don't know the whole homebox API. In fact, all the new functions added in this patch need PHPDoc comments explaining WTF they're for. ;)

B) What do I have to do to test this?

Thanks,
-Derek

drumm’s picture

drumm
he/him
Location NY, US
commented
StatusFileSize
new homebox.patch39.89 KB

A) New patch attached.

B) To test:
1. Install homebox and patch from #874790: Configurable blocks
2. Enable the 'issue cockpit' block, drupalorg provides a default configuration in-code
3. Click the Gear icon and type in a different project.

drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Needs work » Needs review
dww’s picture

dww
we/he/they
commented
Status: Needs review » Needs work

Wrong patch. ;)

drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Needs work » Needs review
StatusFileSize
new project_issue.diff3.33 KB
dww’s picture

dww
we/he/they
commented
Title: Add Drupal core issues block to dashboard » Expose per-project issue block to homebox
StatusFileSize
new 898180-10.issue_homebox_block.B.patch5.54 KB
new 898180-10.issue_homebox_block.A.patch3.49 KB

Re-rolled to fix up some comments and fix a potential PHP notice. (898180-10.issue_homebox_block.A.patch)

Based on an IRC conversation with drumm, I also sort of added support to let users configure which categories should appear in the block via homebox (898180-10.issue_homebox_block.B.patch). However, this doesn't actually work given the custom caching this block is doing. :( So, if we want to support that feature, we need to revisit this caching approach.

I finally managed to test all this on solr.redesign.devdrupal.org, so I've seen it working and am basically ready to commit patch A.

drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Needs review » Reviewed & tested by the community

#874790: Configurable blocks was committed.

dww’s picture

dww
we/he/they
commented
Status: Reviewed & tested by the community » Fixed

Committed #10.A to HEAD.

dww’s picture

dww
we/he/they
commented
Issue tags: +drupal.org redesign sprint 5

(Although this was developed in sprint 4, it was only committed in sprint 5, so tagging it for both sprints).

Status: Fixed » Closed (fixed)
Issue tags: -drupal.org redesign, -drupal.org redesign project, -drupal.org redesign dashboard, -drupal.org redesign sprint 4, -drupal.org redesign sprint 5

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +drupal.org redesign, +drupal.org redesign project, +drupal.org redesign dashboard, +drupal.org redesign sprint 4, +drupal.org redesign sprint 5

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.