This resolves an issue I had with module_invoke() being called too late. The query immediately preceding relies on the global $theme_key, which may not be set before the query is run, resulting in an empty block return value. This patch simply moves the module_invoke() call to before the query, ensuring that the $theme_key variable is set.

CommentFileSizeAuthor
#4 896324-4.patch1.82 KBjpmckinney
apachesolr_search.module_invoke.patch1.25 KBAnonymous (not verified)

Comments

jpmckinney’s picture

jpmckinney commented
Status: Active » Reviewed & tested by the community

Looks harmless, and I assume it fixes the bug.

Anonymous’s picture

Anonymous (not verified) commented

It fixed it for me.

robertdouglass’s picture

robertdouglass commented
Version: 6.x-2.x-dev » 6.x-1.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

#896324 by ahankinson | jpmckinney: Fixed module_invoke() called too late.
Committed to 6.2. Needs to be reviewed for 6.1, and 7.x.

jpmckinney’s picture

jpmckinney commented
StatusFileSize
new 896324-4.patch1.82 KB

Fixed in 7.x

jpmckinney’s picture

jpmckinney commented
Status: Patch (to be ported) » Fixed

6.1 doesn't have apachesolr_search_browse.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.