protyze [protyze]

Hello, and thanks for applying for a CVS account. I am adding the review tags, and some volunteers will review the code, pointing out what it needs to be changed.

• The points reported in this review are not in order or importance / relevance.
• Most of the times I report the code that present an issue. In such cases, the same error can be present in other parts of the code; the fact I don't report the same issue more than once doesn't mean the same issue is not present in different places.
• Not all the reported points are application blockers; some of the points I report are simple suggestions to who applies for a CVS account. For a list of what is considered a blocker for the application approval, see CVS applications review, what to expect. Keep in mind the list is still under construction, and can be changed to adapt it to what has been found out during code review, or to make the list clearer to who applies for a CVS account.

1. The version line needs to be removed from the .info file.

2.     else {
         drupal_set_message(t('Die XML-Datei konnte nicht geladen werden! Überprüfen Sie den Dateipfad.'), 'error');
       }
   
   

   Strings passed to t() must be in English.

3. The module doesn't implement hook_uninstall().

4.   // if there are hotfolders defined, crawl them
     foreach ((array) $hotfolders as $hotfolder) {
       $hotfolder = trim($hotfolder);
       if (file_check_directory($hotfolder)) {
         if ($handle = opendir($hotfolder)) {
           while (false !== ($file = readdir($handle))) {
             if (pathinfo($file, PATHINFO_EXTENSION) == 'xml') {
               // add the xml file to array
               $files[] = $hotfolder . '/' . $file;
             }
           }
           closedir($handle);
         }
       }
     }
   
   

   Why isn't the code calling file_scan_directory()?

5.   if ($success) {
       $message = t('@count Nodes imported!', array('@count' => count($results)));
     }
   
   

   Why isn't the code using format_plural()

6.   $form['xml2node_filepath'] = array(
       '#type' => 'textfield',
       '#title' => t('XML File'),
       '#default_value' => 'sites/default/files/',
       '#size' => 60,
       '#maxlength' => 250,
       '#description' => t('The path to the XML File you would like to import.'),
     );
   
   

   The default value should be the value used the last time the same form has been used. If users need to use a different value, they would need to enter the value they want to use all the times they use the form.

7. /**
    * Implementation of hook_form_submit().
    *
    * @param unknown_type $form
    * @param unknown_type $form_state
    */
   
   

   Hook implementation comments should be like the following one:

   /**
    * Implements hook_menu().
    */
   

   The comment doesn't report the parameters used by the hook, as they are already known, and don't change for each implementation of the hook.

8.   $form['xml2node_hotfolders'] = array(
       '#type' => 'textarea',
       '#title' => t('Hotfolders'),
       '#default_value' => variable_get('xml2node_hotfolders', ''),
       '#rows' => 4,
       '#description' => t('Add Hotfolders to be crawled on crun (each line, one path relative to the base path)'),
     );
   
   

   Crun?

Thank you for your contribution!
I am going to update your account so you can opt into security advisory coverage now.
These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

I am giving credits to the users who participated in this issue.