Hi,

I've written a patch that removes the varying constant and replaces it with a get function. This doesn't change the functionality of this module but does make it easier to read and in line with best practice.

Cheers,
Rim

CommentFileSizeAuthor
jquery_no_variable_constant.patch1.24 KBrimian
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Status: Active » Postponed (maintainer needs more info)

Why?

rimian’s picture

rimian CreditAttribution: rimian commented

Because a constant is supposed to be a constant! If it's the result of an expression then it's variable.

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ at Acquia commented
Issue summary: View changes
Status: Postponed (maintainer needs more info) » Closed (outdated)

Version for Drupal 6 is not supported anymore, closing.