Get rid of the [node:type] hack?

+++ flag.module
@@ -382,19 +382,25 @@ function flag_field_extra_fields() {
-          '#title' => $flag->get_label('flag_short', $form['#node_type']->type),
+          '#title' => $flag->get_label('flag_short', 'bogus'),

I don't understand much about the flag object's caching system at all, but I wonder: what happens here if there happens to be a node type on the system called 'bogus'?

Upping the version.

On further reflection, it seems to me that this patch adds more workaround code than it removes, and while currently the hack code is in just one place where it seems fairly well documented, the workaround code the patch adds is scattered around.

Therefore, as (I assume) the current system works, I think I prefer it to the proposed change. Hence this is wontfix, sorry.

Reopening this, as it affects #1784402: fold handling of node forms into hook_field_attach_form(), remove hook_form_alter() for node forms.

It seems to me that we could get rid of this entirely. On D7, a node form actually has a proto-node in $form['#node'] which presumably can be used for tokens. So we could pass that rather than fake up our own node object.

The only hurdle is that the whole get_label() system works on entity IDs rather than entities...

Ok now having read the patch AGAIN, I finally see what it's getting at.

Changing get_label() so it passes around full entities is going to be a major piece of work, and also it's going to run into all sorts of trouble in places where we don't have the full entity, such as Views.

Therefore this setting of fake or new entities into the flag cache is the best thing to do.

Updated patch for D7.

It turns out now we have a flag_entity class, we don't need any special token handling for node at all.