Occasionally, when dealing with data that was migrated/converted from something else it can be a large hassle to handle incorrectly entered address information. A particular problem is the province field, which Location.module expects to be a one, two, or three-character string that is uppercased to fit the lookup arrays stored in the 'supported' directory. It would be occasionally useful if, until the data can be manually massaged & verified, province strings that were not found in the supported index for the specific country could be passed through to the front end as-is.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

DamienMcKenna’s picture

Status: Active » Needs review
FileSize
1.18 KB

Here's a patch that only uppercases the string if it is two characters in length.

Feel free to mark this as WONTFIX as this is kind of a fringe issue that in normal circumstances shouldn't happen.

podarok’s picture

Version: 6.x-3.1 » 7.x-3.x-dev

all feature requests should be rolled against latest 7.x-3.x-dev and after commit can be backported to 6.x branch

Status: Needs review » Needs work

The last submitted patch, location-n890290.patch, failed testing.

jwilson3’s picture

Title: Dealing with converted data & uppercase province names » Pass-through unknown province names imported from migrated data
Issue summary: View changes
Status: Needs work » Needs review
FileSize
499 bytes
499 bytes

Code in D6 has changed significantly since this patch was created, so I've updated the patch to work with how the province names work in the version 3 branch of both D7 and D6 to let unknown province codes pass through as-is.

  • podarok committed 7fdf2c2 on 7.x-3.x authored by jwilson3
    Issue #890290 by jwilson3, DamienMcKenna: Pass-through unknown province...

  • podarok committed 1ec2f8d on authored by jwilson3
    Issue #890290 by jwilson3, DamienMcKenna: Pass-through unknown province...
podarok’s picture

Status: Needs review » Fixed

@jwilson3 thank you tons.
Committed to both branches

jwilson3’s picture

Sweet! Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.