text format help text uses wrong headings

I'll take this one!

This should nail it!
It adds a H3 in case of a comment form, and a H2 in all other forms :)

I changed the font size of the H2 in the node/add form to keep in equal to the current font-size.

WAIT A MINUTE ;)

This is evil...
Look at #889764: Text format selection layout is broken. and help that one ;)

Not rly a duplicate but this issue is just not relevant.

I was working on #889764: Text format selection layout is broken. as well ;)
But that is another issue, the heading still should use the proper level.

Not sure I agree with this, like to hear about this from accessibility team who I believe made the change from label to heading level before we go switching this to H2, must have been some rational there (or maybe not?).

I don't see a real accessibility problem with using better nested headings. There are a number of situations in Drupal core where headings don't next properly because we cannot programmatically determine the level of the previous appropriate heading in the DOM.

If when can get it to work as it should be, why wouldn't we?

WCAG1.0 states: http://www.w3.org/TR/WCAG10-HTML-TECHS/#document-headers

Since some users skim through a document by navigating its headings, it is important to use them appropriately to convey document structure. Users should order heading elements properly. For example, in HTML, H2 elements should follow H1 elements, H3 elements should follow H2 elements, etc. Content developers should not "skip" levels (e.g., H1 directly to H3).

Also see (good read): http://www.sitepoint.com/blogs/2007/01/26/the-hard-facts-about-heading-s...

@BarisW

WCAG 1.0 is not authoritative as it is over 10 years old and has been superceeded by WCAG 2.0.

Nevertheless, where we have the ability to nest headings correctly we should.

I've already mentioned elsewhere that heading tags are the wrong tool for most labels. Now, if we happen to output headings that break the hierarchical structure of the document/section, then those headings need to be reverted.

See you over in the now re-opened #882666: Core form descriptions shouldn't use a label when not associated with a form, which is the cause for this issue.