Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
There's some tabs in code
Comment | File | Size | Author |
---|---|---|---|
#7 | tb_story_cleanup-d6.patch | 1.04 KB | andypost |
#5 | tb_another_cleanup-d6.patch | 13.81 KB | andypost |
#3 | tb_another_cleanup-d6.patch | 13.72 KB | andypost |
tweetbutton-cleanup-d6.patch | 2.6 KB | andypost | |
Comments
Comment #1
xmacinfoThere is a spelling error in the line starting with:
+ retrun t('This button allows your . . .
Comment #2
chia CreditAttribution: chia commentedThanks, added to 6.x-1.x
Comment #3
andypostAnother round of cleanups.
- Fixes for $Id$ (should be exactly $Id$) #882084: Where to configure it?
- Removed unused .js file
admin.inc
- node_get_types('names') returns what we need
- menu description should be one line or cant be translated
.css
- removed unused #tweetbutton {}
- removed trailing spaces and tabs
- fixed code style as coder module suggests
Comment #4
andypostAlso D6 has no 'article' node type - replaced with 'story'
Comment #5
andypostAnd this changes should go into D7 (needs more cleanups)
Comment #6
timmillwoodCommit to 6.x-1.x-dev.
Comment #7
andypostLast commit does not fix a default value for variable (there's no article node-type in D6)
Also
$op == 'view
Better move to a start of condition: other nodeapi invocations will not call user_access()Comment #8
Anonymous (not verified) CreditAttribution: Anonymous commentedI wanted to move the widget.js to my footer. I've never written a patch before (maybe someone else can for me) but this is what I did:
around line 89:
Replace:
with:
Mostly taken from the Google Analytics module. I'll also note that !title wasn't showing up in my data variable and after I moved the widget.js to the footer the title started showing up in my tweets. Woohoo!
Comment #9
egomac CreditAttribution: egomac commentedThe theme_tweetbutton_display should be flexible so the function can be used to display the button anywhere else (e.g other modules and template). Developers should be able to call the function elsewhere (outside node view).