Hey guys -

I've mentioned this in the past but am only now getting around to addressing it. When a user has many files in his account, the form in the "User edit page" lists all of these in a way that isn't very efficient, and oftentimes we'll get a memory exhaustion error resulting in a WSOD.

My initial idea is to simply move this fieldset to the "Files" tab, where it makes sense to have it. This way the Files are separate from the normal User Edit Form and won't hinder our ability to change user roles, passwords, etc.

CommentFileSizeAuthor
#5 885010-uc_file-user-admin.patch5.26 KBlongwave
#1 885010.uc_file.module.patch849 bytestorgospizza
#1 885010.uc_file.pages_.patch1.13 KBtorgospizza

Comments

torgospizza’s picture

torgospizza
he/him
Primary language English
Location Portland, OR
commented
StatusFileSize
new 885010.uc_file.pages_.patch1.13 KB
new 885010.uc_file.module.patch849 bytes

Attached are two patches that do this. Two files being patched: uc_file.module and uc_file.pages.inc. Not a major change but it could use some testing...

It's rolled against both 2.4 and -dev, which appear the same.

Thanks for looking!

torgospizza’s picture

torgospizza
he/him
Primary language English
Location Portland, OR
commented

I realized my patch(es) don't include any submit button. Let me work on that and then I'll update the issue.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Component: Code » File downloads

Changing component.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

Marked #750016: Large numbers of file downloads for a user causes memory exhaustion in user edit form. as duplicate

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Needs review
StatusFileSize
new 885010-uc_file-user-admin.patch5.26 KB

Patch attached based on the above. The form has validate and submit handlers now, and theme_uc_file_hook_user_file() has been removed as everything it does can be done in the form builder itself.

torgospizza’s picture

torgospizza
he/him
Primary language English
Location Portland, OR
commented

Thank! Will test this out on a staging server soon.

tr’s picture

tr commented

#5: 885010-uc_file-user-admin.patch queued for re-testing.

torgospizza’s picture

torgospizza
he/him
Primary language English
Location Portland, OR
commented

Awesome, thanks for picking up the slack on this!

tr’s picture

tr commented
Version: 6.x-2.x-dev » 7.x-3.x-dev
Status: Needs review » Patch (to be ported)

Committed! Should be ported to 7.x-3.x.

Should we do the same thing with the Ubercart roles administration - move it to a Roles tab (user/%/roles) that shows up only for the administrator? Seems to be a bit out of place where it currently is, now that the file administration has been moved.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Patch (to be ported) » Fixed

Ported and committed to 7.x: http://drupalcode.org/project/ubercart.git/commitdiff/d85720e

Agree that we should do the same thing with the roles admin, but that should be a new issue.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.