Just trying to reduce the .module file in its size.
Trying to bring everything mail and spool related into simplenews.mail.inc. The module seems to be some more ordered then.

CommentFileSizeAuthor
#5 simplenews_883376_5_separate.patch1.09 KBmiro_dietiker
#1 simplenews_883376_separate.patch50.67 KBmiro_dietiker

Comments

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Active » Needs review
StatusFileSize
new simplenews_883376_separate.patch50.67 KB

Providing patch for a first version. What do you think of this separation?

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented

The code was tested completely to work.
Any objections to separate the module this way?

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Looks fine.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Version: 6.x-2.x-dev » 7.x-1.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Committed to repo, needs port.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
StatusFileSize
new simplenews_883376_5_separate.patch1.09 KB

Missed two includes. Committed.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Patch (to be ported) » Fixed

committed to cvs.

DrupOn’s picture

DrupOn commented
Status: Fixed » Closed (fixed)

all mail related functions separated into includes/simplenews.mail.inc for D7 version.