Feeds has this function:

<?php
/**
 * Decides if it's possible to use cURL or not.
 *
 * @return
 *   TRUE if curl is available, FALSE otherwise.
 */
function http_request_use_curl() {
 
$basedir = ini_get("open_basedir");
  return
function_exists('curl_init') && !ini_get('safe_mode') && empty($basedir);
}
?>

And it is used to decide whether to use drupal_http_request() or cURL (called by feeds) when fetching feeds by the default http fetcher.

This is all well and good, and I'm sure there are good reasons for using cURL, but in some cases using drupal_http_request() is needed, like when you've already hacked it to use cURL (say, if you needed to authenticate to a proxy, using SSL.) Now, I don't want to maintain my hack in two different places, so could we just get a 'hidden' variable that forces feeds to never use cURL. I.e. the above function just returns FALSE, in that case.

Files: 
CommentFileSizeAuthor
#7 feeds-883342.patch1.45 KBSteven Jones
#5 feeds-883342.patch832 bytesSteven Jones

Comments

alex_b’s picture

I'd accept such a patch.

beanworks’s picture

Hmm. When will such a patch be available?

Daniel A. Beilinson’s picture

Hello!

In my case curl -I http://drupal.org/node/feed returns

HTTP/1.1 200 OK
Server: Apache/2.2.3 (CentOS)
X-Powered-By: PHP/5.2.11
X-Drupal-Cache: HIT
Etag: "1287266988-0"
Cache-Control: public, max-age=60
Last-Modified: Sat, 16 Oct 2010 22:09:48 +0000
Expires: Sun, 19 Nov 1978 05:00:00 GMT
Vary: Cookie,Accept-Encoding
X-PF-Uncompressing: 1
Content-Type: application/rss+xml; charset=utf-8
Content-Length: 57792
Date: Sat, 16 Oct 2010 22:34:22 GMT
X-Varnish: 307457558 307417402
Age: 1446
Via: 1.1 varnish
Connection: keep-alive

But I received damned -1003 code without forcibly returning FALSE to this function.

Steven Jones’s picture

Assigned:Unassigned» Steven Jones
Issue tags:+Steven's gardening time

Will do this when I get time.

Steven Jones’s picture

Assigned:Steven Jones» Unassigned
Status:Active» Needs review
Issue tags:-Steven's gardening time
StatusFileSize
new832 bytes

Patch attached.

alex_b’s picture

Status:Needs review» Needs work

This looks good. Can we get documentation in README.txt for it? (see hidden variables section).

Steven Jones’s picture

Status:Needs work» Needs review
StatusFileSize
new1.45 KB

Ooo...didn't know about that section in the readme.

Patch attached.

alex_b’s picture

Status:Needs review» Reviewed & tested by the community

Thanks!

alex_b’s picture

Version:6.x-1.x-dev» 7.x-2.x-dev
Status:Reviewed & tested by the community» Patch (to be ported)

Committed, needs a D7 port now.

http://drupal.org/cvs?commit=443292

alex_b’s picture

Status:Patch (to be ported)» Fixed

#7 Applied to 7.x 2.x fine:

http://drupal.org/cvs?commit=443296

Thank you!

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

lindsayo’s picture

posted in the wrong node, apologies.

-L