Checker fieldset is not displayed - javascript syntax problem

It should be in a collapsed fieldset near the bottom of the page.

Try clicking "Save configuration."

You might try re-downloading the current -dev. Obviously I am always at the current -dev release and it shows fine for me.

I'm using Views 6.x-2.11 and I have seen it stomp on other URLs, which is warned about somewhere in the docs. Views does a hook_menu_alter, so it runs after module menu items are created. Any module could also do a hook_form_alter and change the form. The only unlikely culprit I could see doing that would be Linkchecker, but I haven't looked at it to see. If you have that module, you might disable it and see if WL operates correctly.

Just changing Views isn't enough. You have to look at all the menu entries it creates and see if any is a duplicate. But the fact that the page shows up at all kind of says that is not the problem.

It looks like WL's link check is turned off, even though the options say on. Try setting it to "no' and see if maybe the options are backwards, even though it looks okay on my system. If not, then set it back to "yes" and see if that clears it up.

The last resort is to completely remove the module Including deleting it from your system) and re-download and install. There may be some piece floating around from an older release.

You wont lose those unless you uninstall the module. if you uninstall then you lose all you data.

Thanks
Robert

Fabulous. Glad that was it.

FYI, any time a module is removed, the taxonomy vocabulary will remain, but will be disconnected from the content type, so you would have to re-select the content type in the vocabulary. If you had uninstalled WL then you would have lost it all.

Okay,given the warnings above, let me try to be very clear.

1. Put the site into maintenance mode, or better yet, do this on a test copy.
2. Delete the module directory entirely. (Do NOT disable or uninstall the module.)
3. Check to see if it is still works (another copy hiding somewhere).
4. Download the latest -dev.
5. Clear the caches (admin/settings/performance, or Devel)
6. Check to see if it works.
7. Check to see if any updates need to run again.

If you find another copy hiding somewhere, you'll have to hunt for it and delete that before continuing. -- I'd say that there is a chance this is the cause. Actually, the system table could help find it. If you're comfortable in the database, you might even look there before doing anything else.

I cannot even come close to reproducing this. I hate to ask for access to your site.

Do you mean like the attached image (from your site)?

I was using IE7.

I'm going to guess then that there is a broken HTML tag in there somewhere. If you can, try running it through the HTML validator and let's see if it can locate it.

Somebody is messing with your body tag, but that is definitely not Web Links. That would have to be in your page.tpl.php file in your theme. span id="liveclock" is probably that clock you show; also not WL.

Seeing this, I would suggest removing the clock and see if that is the culprit.

Oh, yeah??? I need a date. ;-)

I admit to not being a JavaScript aficionado. That variable is used on lines 4 and 28 in weblinks_checker.js, and it is certainly acting like that could be the problem.

Robert if you see this, could you check that js code, please?

I don't need this feature for now, but I can confirm that on mine anytime I edit the settings, I can see the image on #24 expanded for 1/2 second, and settles back as on image given on #2. I was thinking that might be some users dont know this option exists.

I could reproduce the problem and found the same JavaScript syntax error as reported in #31 by Starminder.

Patch is attached.

BTW: a similar problem exists on the Web Links settings page.

I have also added a patch which fixes this.

What browser and version are you using? I cannot replicate the error - I'm on a mac, and tried Firefox 41.0.1, Chrome 45.0 and Safari 6.2.6

The D7 code has does not have the '@' so that's good.

What browser and version are you using?

Firefox 41.0.1 under Windows.

I cannot replicate the error

The syntax error was displayed in the Firefox Konsole. After changing the JavaScript code the syntax error disappeared and the page is displayed correctly.

The D7 code has does not have the '@' so that's good.

Yes, that motivated me to create the patch.

Do you have an idea what the '@' character stands for?

The @ is often used in Drupal to indicate "do not return an error." I don't know if that is true in JS as well.

I don't know if that is true in JS as well.

I would say No.

Tests using IE11, Chrome 45 und Windows and Safari 9 under OS X exhibited the syntax error as well. And the Web Links checker page will be not fully displayed.

The syntax error is also raised when using Firefox 41 and Chrome 45 under OS X 10.11.

The D7 code has does not have the '@' so that's good.

In fact, I changed the D7 JavaScript code during the port from D6 to D7 as desribed in "Converting 6.x modules to 7.x", https://www.drupal.org/update/modules/6/7#javascript_compatibility, section jQuery 1.3.x.

So this issue will occur when switching from JQuery 1.2.x to 1.3.x.

Right, that's a very helpful link. Thanks.

The syntax error is also raised when using Firefox 41 and Chrome 45 under OS X 10.11

I was looking in the console, and using OS X 10.8, Firefox 41, Chrome 45 and still cannot see the error. Maybe it is dependent on the jquery module version, I am on 6.x-1.5 and my status page says jQuery UI is 1.6.

Using the @ was obviously correct at the time for D6, but now after some combination of newer versions/upgrades it fails. I think we should now what in particular causes the failure, so that if you do make the code change and users later have problems we can point to the cause. We don't want to introduce new bugs in D6 without being aware of the consequences.

In D7 we can probably do away with that .js file completely and re-write the functionality with drupal behaviours, directly into the form items. But that's a separate task anyway.

Maybe it is dependent on the jquery module version,

Definitely.

I am on 6.x-1.5 and my status page says jQuery UI is 1.6.

What is version 6.x-1.5? I'm using jQueryUpdate 1.3.2 and jQuery UI is also 1.6.

We don't want to introduce new bugs in D6 without being aware of the consequences.

Sure. Maybe this article is helpful: https://www.drupal.org/node/1058168

6.x-1.5 is the version of the Drupal jquery UI module that I installed on my D6 site a long while ago. I do not have the jquery update module installed at D6.

Whilst I cannot replicate the syntax errors you are seeing, I've tested your patches in #37 and #38 and the jquery functionality works fine with the @ removed. I am happy for you to commit both of these.

Thanks for your review. If you don't mind I will commit the patches now.