Closed (fixed)
Project:
Media Mover
Version:
6.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
7 Aug 2010 at 19:43 UTC
Updated:
1 Oct 2010 at 22:00 UTC
I believe the reason for this is that functions like unlock() in class_media_mover_file are currently testing whether they are on the last step by checking step_count(). This would work except that step_order seems to start at 0, so count != step number.
I've attached a patch for the solution I'm using at the moment, which was to add a last_step() function to class_media_mover_configuration, and changed instances of step_count() in class_media_mover_file.php to last_step()
An alternative solution would just be to modify the step_count() function, but I felt like that was not as clear as step_count() does return the correct value and may be useful elsewhere.
| Comment | File | Size | Author |
|---|---|---|---|
| last_step.patch | 2.01 KB | civicpixel |
Comments
Comment #1
civicpixel commentedComment #2
arthurf commentedCommitted and ready for testing
Comment #3
civicpixel commentedTested on our development and live servers for a week, marking as fixed.