When I login as a user with no permissions to "search content", and take a look at the taxonomy page, I see a search form and the filter-blocks on the right.
"Make Apache Solr Search the default" is enabled.
"Use Apache Solr for taxonomy links" is enabled.
Possibly test for the "search content" permission before displaying the search form and the blocks?
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | 871440-taxo-access-12-D7.patch | 3.08 KB | pwolanin |
| #9 | 871440-solr-taxonomy-access-check-D6.patch | 5.41 KB | elliotttf |
| #7 | 871440-D6.patch | 5.37 KB | jpmckinney |
| #6 | 871440-D6.patch | 5.09 KB | jpmckinney |
| #5 | 871440-D7.patch | 3.05 KB | jpmckinney |
Comments
Comment #1
jpmckinney commentedComment #2
jpmckinney commentedComment #3
jpmckinney commentedWow, was that function broken.
* $title undefined
* allowed access to $tids that the user may not have access to
* calls drupal_add_feed twice if it calls back to taxonomy_term_page
* uses search_help('search#noresults', drupal_help_arg()) instead of variable_get('apachesolr_search_noresults', apachesolr_search_noresults())
* and, as noted here, doesn't check user_access('search content')
Synced this function better with taxonomy_term_page
Comment #4
jpmckinney commentedSame patch applies to 6.x-2.x
Comment #5
jpmckinney commentedPatch for 7. Note that D7 doesn't fail back to taxonomy_term_page. It also doesn't have the check:
Comment #6
jpmckinney commentedUpdated D6 to set breadcrumb as in taxonomy_term_page.
Comment #7
jpmckinney commentedMerging #716104: Taxonomy hijack should fall back if SOLR is not present into this. Fixed watchdog error to be more descriptive, too.
Comment #8
jpmckinney commentedHopefully this will also fix #937398: Taxonomy Solr page: WSOD if no content has been indexed yet.
Comment #9
elliotttf commentedOne thing I did find, if using PHP 5.3 you'll get a strict warning on the taxonomy page. This problem actually exists in the taxonomy module too, but can be fixed by initializing the $current object before using it:
I've rerolled the patch with that one change but otherwise the patch looks good to me.
Comment #10
pwolanin commentedcommitted to 6.x-1.x and 6.x-2.x
not sure if some of the changes need to made also for 7.x.
Comment #11
jpmckinney commentedSee #5 :)
Comment #12
pwolanin commentedCommitting this for 7 - a couple minor tweaks.