For coordinate type the on-screen instructions say:

"Lat/Lon argument format: lat,lon_distance"

This is incorrect, the correct format is:

"Lat/Lon argument format: lat,lon_lat_distance,lon_distance"

Small patch attached

CommentFileSizeAuthor
#1 location-868516-2.patch1.25 KBhutch
patch.txt810 bytesAnonymous (not verified)
Members fund testing for the Drupal project. Drupal Association Learn more

Comments

hutch’s picture

FileSize
1.25 KB

The description is indeed inadequate, 'distance' can be ither a number or a pair of decimal degrees, comma delimited.
patch_344.txt is the wrong way around and has too many commas.

The most informative patches are made on a fresh checkout, on DRUPAL-6--3 so that the patch builds on the current dev, using the following command from the location module folder:
cvs diff -up > location-868516-2.patch

This shows us which module, which issue and which patch in that issue.

This format gives a unified diff, showing what class/function it is being applied to, with the revision number and the path to the file.

YesCT’s picture

Status: Active » Needs review

totsubo, thanks for starting this.

Anonymous’s picture

My pleasure!

Sorry for the patch not being quite up to snuff but I don't get my updates from CVS but just download the latest stable version. (Come to think of it I don't even have a CVS account or CVS set up on my machine).

I wish I could contribute more in terms of coding but in the mean time the least I can do is help make modules better by reporting bugs :)

YesCT’s picture

totsubo, I dont use CVS for making patches, I just click on "dev" version and use that one. :)

rooby’s picture

Status: Needs review » Fixed

Committed patch in #1 to 6.x-3.x and HEAD. Thanks.

http://drupal.org/cvs?commit=474920
http://drupal.org/cvs?commit=474922

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.