Lat/Lon argument format description incorrect [#868516]

For coordinate type the on-screen instructions say:

"Lat/Lon argument format: lat,lon_distance"

This is incorrect, the correct format is:

"Lat/Lon argument format: lat,lon_lat_distance,lon_distance"

Small patch attached

Comment	File	Size	Author
#1	location-868516-2.patch	1.25 KB	hutch
#1
	patch.txt	810 bytes	Anonymous (not verified)

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

hutch CreditAttribution: hutch commented 29 July 2010 at 19:10

File	Size
location-868516-2.patch	1.25 KB

The description is indeed inadequate, 'distance' can be ither a number or a pair of decimal degrees, comma delimited.
patch_344.txt is the wrong way around and has too many commas.

The most informative patches are made on a fresh checkout, on DRUPAL-6--3 so that the patch builds on the current dev, using the following command from the location module folder:
cvs diff -up > location-868516-2.patch

This shows us which module, which issue and which patch in that issue.

This format gives a unified diff, showing what class/function it is being applied to, with the revision number and the path to the file.

Comment #2

YesCT CreditAttribution: YesCT commented 30 July 2010 at 03:58

Status:

Active

» Needs review

totsubo, thanks for starting this.

Comment #3

Anonymous (not verified) CreditAttribution: Anonymous commented 30 July 2010 at 12:20

My pleasure!

Sorry for the patch not being quite up to snuff but I don't get my updates from CVS but just download the latest stable version. (Come to think of it I don't even have a CVS account or CVS set up on my machine).

I wish I could contribute more in terms of coding but in the mean time the least I can do is help make modules better by reporting bugs :)