I'm not positive this is a good idea, especially this many months after UX freeze (won't be offended if this gets pushed to D8 :D), but I was updating Using Drupal tonight which forced me to take a thorough look at the D7 UI, which I haven't done in awhile. This stuck out to me:

Weird that the option to show/hide comments is so far down the page

Since the setting of the "Default setting for new content" value dictates whether the rest of those options even matter, it seems like it should be at the top of the page like it was in D6.

It was also very awkward to write that the way to disable comments on a content type was to "Change the 'Default setting for new content' setting to "Hidden"' as opposed to the old instructions, which were "Change 'Default comment settings' to 'Disabled'". I'm sure we had a good reason for that at one point, but it feels a bit obtuse when I actually write it down as a set of instructions.

Any-hoo...

CommentFileSizeAuthor
#15 drupal.coment-node-type-options.15.patch2.15 KBsun
#6 drupal.coment-node-type-options.6.patch942 bytessun
#3 comment-form.patch1.49 KBjbrown

Comments

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Issue tags: +Usability

.

Bojhan’s picture

Bojhan commented

Yes, patch please? :)

I am not that confident about changing the label this late in the game, where else do we use hidden?

jbrown’s picture

jbrown commented
Status: Active » Needs review
StatusFileSize
new comment-form.patch1.49 KB
bleen’s picture

bleen commented
Status: Needs review » Reviewed & tested by the community

makes sense to me ... looks good

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Fixed » Needs review
StatusFileSize
new drupal.coment-node-type-options.6.patch942 bytes 
+++ modules/comment/comment.module	30 Jul 2010 01:26:04 -0000
@@ -1083,6 +1083,12 @@
+      '#type' => 'select',
+      '#title' => t('Default comment setting for new content'),
+      '#default_value' => variable_get('comment_' . $form['#node_type']->type, COMMENT_NODE_OPEN),
+      '#options' => array(t('Hidden'), t('Closed'), t('Open')),

Sorry, could not resist. Additionally,

1) Those labels presume certain internal values, without declaring them.

2) It makes little sense for me that "Hidden" is the first (and therefore suggested) option.

3) For any reason, we went with radios instead of a select in the node edit form. Why is it a select in the node type form here? Also, the radio buttons have a short description for each option. See http://api.drupal.org/api/function/comment_form_alter/7

Attached patch changes 1) and 2).

Powered by Dreditor.

Bojhan’s picture

Bojhan commented

Wait no, why is hidden more common then open?

also requires screenshots

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

@Bojhan: That's the point. The current code in HEAD puts "Hidden" first, whereas we should put "Open" first, just like we do elsewhere. Regarding screenshots... as of now, this patch just changes the order of options within a select list, which is not easy to capture.

Bojhan’s picture

Bojhan commented

/me shuts up - thanks :)

andypost’s picture

andypost
he/him
Primary language Russian
commented

Why this does not use states to hide other settings while closed/hidden?

moshe weitzman’s picture

moshe weitzman commented

I think we don't use #states because this is just a default read-only. some nodes could choose to be commentable in which case the values here are in effect.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

Exactly what moshe said. Since I also considered that while doing the patch, it might be worth to add a code comment.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Reviewed & tested by the community

Sure! So this patch is required

Bojhan’s picture

Bojhan commented
Status: Reviewed & tested by the community » Needs work

andypost is confusing me, sun stated it needed a code comment.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs work » Needs review
StatusFileSize
new drupal.coment-node-type-options.15.patch2.15 KB

Added a code comment about purposively not using #states, and cleaned up some other wonky s...

Bojhan’s picture

Bojhan commented
Status: Needs review » Reviewed & tested by the community

Back to RTBC, although this is polish - it does effect the "content creation" form. Which is a very important page in Drupal.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Agreed; this is good clean-up, and doesn't result in any visual change.

Committed to HEAD. Thanks!

Status: Fixed » Closed (fixed)
Issue tags: -Usability

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Usability

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.