'0' not displayed as checkbox / radios options (nor as any element #title)

This is bug in includes/form.inc file. We should fix function theme_form_element_label. We need to replace

if (empty($element['#title']) && empty($element['#required'])) {

to

if (!isset($element['#title']) && $element['#title'] != '' && empty($element['#required'])) {

Pushing to form component. There's not much we can do at the Field API level.

@furamag: that fix sounds correct. Care to roll a patch ?

Oops, posted in the middle of changing the title

I would change the condition to
(empty($element['#title']) && ($element['#title'] != 0) && empty($element['#required']))
as if somehow NULL value will come it also should be excluded.

Please review the patch.

What is worrying me more is rendering the field afterwards. Looks like drupal_render() not rendering properly
array('#markup' => 0). Please recheck setting the value of the field to zero and look at node view page.

changing status to 'needs review'

Tested for Drupal7-Beta1. It works fine for latest version of Drupal 7. I manually changed includes/form.inc to fix this bug. But we need to change something in this patch to apply it automatically for Drupal7-Beta1.

Bumping to d8

#6: 866292-5.patch queued for re-testing.

Just a re-roll of patch that was rtbc.

I added a test to check if the label is rendered, be warned this is my first test for core

RTBC, because my patch only added a test, original patch is working

You can't mark your own patch rtbc. It would be better if we had a test only patch so we could see it is failing.

(I don't say something is wrong with your patch)

@aspilicious you're right, but since patch + test is small, I'll just change the status.

Can you mark it as RTBC, if it's checks out?

If you upload a test only patch I can rtbc it.

There are some issues with the patch as is. There are missing periods at the end of comments lines

// Make sure the label is rendered

And we also add a new radio button

  'first-radio' => t('First radio'),
  'second-radio' => t('Second radio'),
  'third-radio' => t('Third radio'),
+ '0' => t('0 checkbox'),

Which isn't used in the tests and also has the wrong name.

Reroll of #12 to fix above and add a test for the radio as checkbox. Also the test should be checking for a t('0') as this is the case of the problem. First patch should fail and second should pass.

@marcingy thanks you're absolutely right, if think I didn't had enough coffee this morning, patch applies cleanly and does what it's supposed todo, so I guess RTBC

+++ b/includes/form.inc
@@ -3948,7 +3948,7 @@ function theme_form_element_label($variables) {
   // If title and required marker are both empty, output no label.
-  if (empty($element['#title']) && empty($element['#required'])) {
+  if (empty($element['#title']) && ($element['#title'] != 0) && empty($element['#required'])) {
     return '';
   }

The added condition somehow conflicts with the first, ultimately very hard to understand. Use the following subcondition instead:

(!isset($element['#title']) || $element['#title'] === '')

20 days to next Drupal core point release.

Reroll taking into account #21

Looks better and is indeed more readable

This cropped up in the Webform queue today: #1363788: Zero integers not exported in CSV/Exel downloads..

Reroll for the core directory move.

Thanks!

Looks good to me. Committed/pushed to 8.x. Moving to 7.x.

Reroll for D7. Exact patch, no changes needed other than removing the /core directory.

Rerolled patch to 7.x

Haha, well I'm guessing that I can RTBC @ygerasimov's #28. :)

Solved the problem in Webform that I was experiencing. It's a little bit weird that we're bothering to translate "0", but since this was already committed to D8 and we don't translate tests anyway, I don't think there's any need to hold this up.

Oh, silly PHP. :P

Committed and pushed to 7.x. Thanks!

Updating tags per http://drupal.org/node/1517250