For a long time, I didn't know that there is a standard for patch file names. I see many different forms in the issue queue, so I guess most people don't know about the standard (described at http://drupal.org/patch/submit under "Name your patch") or do not agree (ie. #577718: patch names?).
I propose that we add a short description of the naming standard to the help text under the file attachment field. For instance: "Name patch files as follows: [module]-[description]-[issue-number]-[comment-number].patch (ie. forum-comment-titles-12345-15.patch). See also http://drupal.org/patch/submit."
I also think that the help text for file attachments on the comment form should be the same as on the node form. Currently, only the comment form contains an addition about automatic testing. Seeing that the help text would get quite long, I'm wondering if we should separate the help text into a bulleted list like this:
- The maximum upload size is 1 MB. Only files with the following extensions may be uploaded: jpg jpeg gif png txt xls pdf ppt pps odt ods odp gz tgz patch diff zip test info po pot.
- Only files ending in .patch or .diff will be sent for testing.
- For patches that apply specifically to Drupal 5 or Drupal 6, you can prefix the extension with -D5 or -D6 to prevent them from being queued for testing. For example, foo.patch and bar.diff would both be queued for testing, whereas foo-D5.patch and bar-D6.diff would not be queued for testing.
- Name patch files as follows: [module]-[description]-[issue-number]-[comment-number].patch (ie. forum-comment-titles-12345-15.patch). See also http://drupal.org/patch/submit.
Comments
Comment #1
dddave commentedThis seems reasonable, doesn't it?
Comment #2
avpadernoAny change to form fields is done through code in the custom module.
Comment #3
drummThe formatting of the help text here was cleaned up as part of the work going into DrupalCI’s launch. The addition of the name suggestion already has a couple proposed solutions.