Because JS translation depends on filenames in .po file (s.location LIKE '%.js%') in _locale_rebuild_js()

It should include the location info for JS files (at least ".js" as location, so it will work with the JS translation in D6/7).

CommentFileSizeAuthor
#6 compact_files_format-864064-6.patch1.06 KBsebcorbin
#5 l10n_server_864064.patch1.37 KBtobiasb
#2 js-compact-export.patch2.16 KBgábor hojtsy

Comments

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

Agreed, thanks for submitting!

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Active » Needs review
StatusFileSize
new js-compact-export.patch2.16 KB

Here is a proposed patch. Looking for testers.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

Anybody interested in helping to test this? I'd love to get this fixed soon.

andypost’s picture

andypost
he/him
Primary language Russian
commented

glad to test this but a week latter

tobiasb’s picture

tobiasb
Primary language German
Location Berlin
commented
StatusFileSize
new l10n_server_864064.patch1.37 KB

Added a new patch without hunks.

I get this as result:

#: in.js
msgid "An HTTP error @status occured."
msgstr "Ein HTTP Fehler @status ist aufgetreten."

(l10n_client)

sebcorbin’s picture

sebcorbin commented
Version: 6.x-2.x-dev » 7.x-1.x-dev
Issue summary: View changes
StatusFileSize
new compact_files_format-864064-6.patch1.06 KB

Rerolled against 7.x, will test that soon

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Version: 7.x-1.x-dev » 3.0.x-dev
Status: Needs review » Closed (outdated)

Drupal 8 and later find the strings of the JavaScript files on the site itself and add their locations then to the database, so the compact .po files work for JavaScript translations equally. Drupal 6 and 7 are not supported any more.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.