Closed (fixed)
Project:
Drupal.org CVS applications
Component:
new project application
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
23 Jul 2010 at 13:39 UTC
Updated:
13 Jan 2019 at 09:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
erikwebb commentedAttaching first copy of commit-worthy code.
Comment #2
erikwebb commentedComment #3
avpadernoHello, and thanks for applying for a CVS account. I am adding the review tags, and some volunteers will review the code, pointing out what it needs to be changed.
As per requirements, the motivation message should be expanded to contain more features of the proposed project. For themes, it should include also a screenshot of the theme, and (when possible) a link to a working demo site using the proposed theme; for modules, it should include also a comparison with the existing solutions.
Comment #4
erikwebb commentedThanks, kiamlaluno.
In the meantime, I've restructured the module to be Coder-compliant and made some further bug fixes. I'm attaching the latest version.
I'm not sure there are other equivalents in existence. The closest comparison I found was the mapping of external login modules to Drupal roles (see LDAP Integration or Shibboleth). This module instead intends to abstract the process of where entitlements come from to allow existing authorization systems to seamlessly integrate with Drupal's internals. The hooks used allow this "entitlements" idea to be expanded to roles, OG subscriptions, or any other characteristic of Drupal users.
In its initial purpose being developed for a current client, they have a system that tracks entitlements to different software downloads in an external system. This is relevant to their internal accounting, but does not fit well with Drupal. They have multiple entitlements for individual software packages depending on contractual requirements. By implementing this module, they may map any available entitlements to individual OG to dynamically restrict permissions in accordance with their pre-existing system.
For end-users where Drupal must coexist with generic authorizations systems with code-based attributes, this module should be flexible enough to be used and extended to interact with any Drupal component. I have had several clients in the past that could benefit from this module and finally had the time to build it with my current client in mind.
Comment #5
erikwebb commentedComment #6
erikwebb commentedHere is a second module I've written - Comment Dropbox. This module allows for Comments to live under a "write-only" system. I'm using this for users to provide feedback privately with only the author and administrators able to read the comments. This is defined on a per-content type or per-node specificity, just like the normal comment settings. Technically, this settings uses a new value of '3' for comment settings rather than the predefined 0-2 values. It makes Drupal think the system is read/write to display the create comment box, but adds an access check on the theme function to hide any comments that a user should not have access to. In function, I have used it for users to submit a document in response to a node without making their submissions public to other users (requires a private filesystem, obviously).
Unfortunately the comment system is very locked down, so the work done here is unavoidably, relatively hacky. It cleanly installs and uninstalls into a current site. Please take this module into further consideration regarding my application.
Comment #7
avpadernoWe just review a module / theme per applicant. Let us know which module you want reviewed.
Comment #8
erikwebb commentedI'm sorry, please review the first module. It should be more substantial and useful to the community.
Comment #9
erikwebb commentedI'm sorry, please review the first module. It should be more substantial and useful to the community.
Comment #10
robertdouglass commentedThere's a stray
dpm($node);Otherwise, looks good.
Now... to the webmasters.... what can we please do about our process to make it less alienating for new contributors? Is there really any good reason why Erik had to wait since July 23 to get the privilege of committing a new module? It's really no wonder that people decide to put their code on github.
Comment #11
robertdouglass commentedI approved this account. Gave Erik the role "cvs user" on his account tab and set his status to "approved" on the CVS tab.
Comment #14
avpaderno