Closed (fixed)
Project:
Mailchimp
Version:
6.x-2.0
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
20 Jul 2010 at 12:07 UTC
Updated:
12 Aug 2010 at 16:50 UTC
Jump to comment: Most recent file
I'm pretty sure there's a small bug in the mailchimp_cron implementation as of 6.x-2.0.
Users will not be moved from "pending" to "current" with this code.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | mailchimp-859326-row-uid.patch | 708 bytes | xurizaemon |
| #1 | mailchimp-859326-row-uid.patch | 708 bytes | xurizaemon |
Comments
Comment #1
xurizaemonACTUALLY DODGY. Check next comment's patch.
Comment #2
xurizaemonPatch. Probably dodgy because I don't have a handy CVS checkout but you should get the idea :)
Comment #3
xurizaemonPatch is against 6.x-2.0 release tarball btw.
Comment #4
xurizaemonThinking that rather than altering this line (so it works before the user_load() happens), we should just transpose the line with the if ( user_load() ) ... that reads a little better to me, even though it should have no practical difference (if user_load() fails, the user should have been deleted from {mailchimp_user} table already).
Comment #5
xurizaemonBtw, symptom for this appears to be that you will have ONE user sitting in 'pending'. The $account->uid variable moved from the queue points to the previously updated user.
What's actually happening is more analogous to this -
Comment #6
levelos commentedI took the approach you suggested in http://drupal.org/user/76026, and went further by adding a delete query in case the user_load() fails.