callum [callum]

Hello, and thanks for applying for a CVS account. I am adding the review tags, and some volunteers will review the code, pointing out what it needs to be changed.

What do you mean by as layar compatible JSON hotspots?

Thank you for your reply.

• The points reported in this review are not in order or importance / relevance.
• Most of the times I report the code that present an issue. In such cases, the same error can be present in other parts of the code; the fact I don't report the same issue more than once doesn't mean the same issue is not present in different places.
• Not all the reported points are application blockers; some of the points I report are simple suggestions to who applies for a CVS account. For a list of what is considered a blocker for the application approval, see CVS applications review, what to expect. Keep in mind the list is still under construction, and can be changed to adapt it to what has been found out during code review, or to make the list clearer to who applies for a CVS account.

1.   ob_start();
     include drupal_get_path('module', 'layar') . '/definitions/layar.cck.inc';
     ob_end_clean();
   

   What is the purpose of calling ob_start(), and ob_end_clean()?
   There is a Drupal function that can be called to load files containing PHP code.

2.         drupal_set_message(t('The POI URL of this layar is: ') . l($GLOBALS['base_url'] . '/layar/' . $node->nid, 'layar/' . $node->nid));
   

   The code should use t()-placeholders, and generate URLs using url(). l() should never be used together t(), as reported in the documentation for t().

3.     echo json_encode($response);                
   

   json_encode() is only defined in PHP5, but Drupal 6 is compatible with PHP4. If the module require a function present in PHP5, then it should declare its dependency from PHP5. The function is only found on PHP 5.2.0 or higher; for other versions of PHP, the module should check if the function is present. There is then a Drupal function that can be used instead of json_encode().

4. The same is true for filter_input(), which is present only on versions of PHP higher or equal to 5.2.0.

1. The function I was referring to is module_load_include().
2. The correct placeholders for URLs start with @.
3. The function layar_getpointsofinterest() should be renamed layar_get_points_of_interest(), or layar_points_of_interest().

4.       if (!in_array(NULL, $fields) && !in_array(FALSE, $fields)) {
           $this->query->add_where($this->options['group'], earth_distance_sql((Float)$fields['lon'], (Float)$fields['lat'], 'location') . ' < %f', (Float)$fields['radius']);
         }
   
   

   Where is the function earth_distance_sql() defined?

5.     $response->errorString = 'Input fields were either missing or failed sanitization.';
   
   

   Strings used in the user interface should be translated.

6. See http://drupal.org/coding-standards to understand how a module should be written. In particular, see how hook implementations should be commented.

7.       '#description' => t('The size of the object in meters squared.'),
   
   

   It's square meters, not meters squared.

    $form['tooltip']['layar_attribution'] = array(
      '#type' => 'select',
      '#title' => 'Layar Attribution',
      '#default_value' => $this->options['tooltip']['layar_attribution'],
      '#description' => t('The attribution of the tooltip box (in italic at the bottom).'),
      '#options' => $fields,
    );

Strings used in the user interface are translated.

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.