This patch actually appears to have some regressions and needs some work; Trevor's patch is against 1.1.2.2 of the file while the current in dev is 1.1.2.5. However, it does seem to have some new features allowing additional settings for the recurring order checkout pane and possibly more. I'll let Trevor chime in here or Chris pull in the features while discarding the regressions... I'm not actually using the module and haven't reviewed it further than this.

CommentFileSizeAuthor
trevor-dev.uc_recurring_order.patch9.19 KBrszrama

Comments

univate’s picture

univate commented
Status: Needs work » Closed (won't fix)

A lot of those settings were actually in the module and I deliberately removed them. I personally have major issues with all the crap ubercart stuffs into the variables table.

The correct way to provide configurable strings in drupal is via the translation system. One option is to use a module like string_overrides. In my opinion having all these options don't really add anything other then provide more options to confuse end users.

I'm marking this issues as won't fix (feel free to re-open if you would like to argue the case for these options).

rszrama’s picture

rszrama commented

Sounds fine to me. They were probably just in his dev work from basing his stuff off the earlier version. I'm not sure he was actually using this module.

trevorwh’s picture

trevorwh commented

That's correct - this was never being used in the module, just an earlier dev version :)

Thanks guys.