Still pondering #719522: show on vocab admin list which vocabs are applied to users., but this seems like a good thing to do too.

CommentFileSizeAuthor
#5 856234-5.user_terms.show-on-vocab-edit.patch1.38 KBjoachim
#3 856234-3.user_terms.show-on-vocab-edit.patch1.36 KBjoachim
#1 856234.user_terms.show-on-vocab-edit.patch1.14 KByeputons

Comments

yeputons’s picture

yeputons commented
Status: Active » Needs review
StatusFileSize
new 856234.user_terms.show-on-vocab-edit.patch1.14 KB

Patch is attached.

joachim’s picture

joachim commented

Lol. I made a patch too, but didn't have time to upload it yesterday... :)

Only differs from yours in the #description. Will commit this soon.

joachim’s picture

joachim commented
StatusFileSize
new 856234-3.user_terms.show-on-vocab-edit.patch1.36 KB

Here's my version of the patch.

Will commit when I'm on a better connection :)

yeputons’s picture

yeputons commented

I think that your patch is better because it checks user's permissions and uses #value instead of #default_value. Also it has more complete description. But I think that we need to use my version of #description because it's more "core-like". Another thing I want to change is correct the second part of description.
So my suggestions are:

+  $description = t('Whether this vocabulary is applied to users.');

to

+  $description = t('Checked if users can be categorized using this vocabulary.')

and

+    $description .= ' ' . t('You may edit this in the <a href="@url">user terms</a> settings.', array(

to

+    $description .= ' ' . t('It can be edited at the <a href="@url">user terms settings page.</a>', array(
joachim’s picture

joachim commented
Status: Needs review » Fixed
StatusFileSize
new 856234-5.user_terms.show-on-vocab-edit.patch1.38 KB

Good call.

I've adapted your change to the second line slightly:

$description .= ' ' . t('This can be edited on the user terms settings page.', array(

Committed this patch.

#856234 by yeputons, joachim: Added indication on vocab admin form that a vocab is applied to users.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.