It would be a big improvement in the approval process if you could show total hours, total approved hours, total rejected hours, and total unapproved hours. These could be put in separate columns on the approval page since there is so much free horizontal space there. It would make it much easier to make sure all hours were either approved or rejected, with none overlooked.

Also, the gray used for the even rows in the table is too dark IMO and has no class to override. I overrode all rows to white with css for now, but it would be nice to have odd/even classes on the rows so that the striping could be styled to match the theme.

Also when approving, it would be nice to have a couple more seconds delay to approve more lines before the update is triggered, because it's a pain to go down to the bottom and re-scroll to the right. OR: Perhaps the scrolling to the left could be avoided after auto-update?

CommentFileSizeAuthor
#2 timesaver-approval.jpg37.39 KBstg11

Comments

_randy’s picture

_randy commented

For the dark row issue, RC3 will have a css class for properly overriding that.

The approval page does show a quick synopsis of approved, total hours etc. I presume you're asking for those values to be broken out in to their own columns rather than shown in a single table cell?

The current delay is 3 seconds. I could pull that out to be a Timesaver configuration parameter. The scrolling to the left happens because the save routine fires and the output of the timesheet you're approving is saved and refreshed via AJAX.

stg11’s picture

stg11 commented
StatusFileSize
new timesaver-approval.jpg37.39 KB

I appreciate your quick response to the request.

Items 1 & 3 solutions sound great. The approval page shows number of items approved, not the number of hours approved. The number of hours approved & total hours together would form a summary check to see if all hours have been processed. In the attachment, you will see there is no figure shown for hours approved.

_randy’s picture

_randy commented

I've committed an update to resolve the css issue on the approval rows. CSS file now has 2 new declarations for evenRow and oddRow at the top of the Timesaver CSS file.

Also added the # of approved hours in the info approval column.

_randy’s picture

_randy commented
Status: Active » Fixed
stg11’s picture

stg11 commented

Thanks, randy

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.