Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
mikeytown's patches in #652690-15: Only process CSS if the browser is IE contain some ideas to refactor this module:
- move some code out into unlimited_css_link($files, &$styles).
- move some code out into unlimited_css_import($files, &$styles).
(or better, remove the &$styles argument and use a return value instead).
I think it would make sense to do this stuff separately and before the other ideas of the above patch, so we have a common ground of discussion for future work.
Comment | File | Size | Author |
---|---|---|---|
#1 | unlimited_css-855040.patch | 2.95 KB | mikeytown2 |
Comments
Comment #1
mikeytown2 CreditAttribution: mikeytown2 commentedComment #2
donquixote CreditAttribution: donquixote commentedThanks.
Now that antonio gave me CVS access, I guess I will take care of this. But not today..
Comment #3
donquixote CreditAttribution: donquixote commentedFixed in next -dev.
See also #912374: Other modules can override $vars['styles'] after unlimited_css_preprocess_page() has run..
Comment #4
klonosSo, is this fixed/committed or not? I ask because it is set to NR.
Comment #5
donquixote CreditAttribution: donquixote commentedDuh, that's still in -dev...
yeah, should get it committed.
I'm doing my taxes and some party first :)
Comment #6
klonosWhat can I say, a man's gotta do what a man's gotta do ;)
Comment #7
donquixote CreditAttribution: donquixote commentedIt's now in 6.x-1.3
Please report if anything behaves strangely.