There is a php notice warning and an undefined variable to fix.

CommentFileSizeAuthor
#4 854856-userpoints-d6.patch1.04 KBandypost
userpoints_php_notices.patch948 bytesjcmarco

Comments

kbahey’s picture

kbahey commented
Status: Needs review » Fixed

Thank you. This is committed now.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Fixed » Needs work

isset/empty - really should be changed only $account/$user

Any reason to get anonymous points? Previous check was done for ignoring $user->uid == 0

kbahey’s picture

kbahey commented

It is not clear to me what you are trying to say.

Do you have a patch for what is in CVS now?

andypost’s picture

andypost
he/him
Primary language Russian
commented
StatusFileSize
new 854856-userpoints-d6.patch1.04 KB

Patch.

isset() is checking for NULL but we should check for 0

kbahey’s picture

kbahey commented
Status: Needs work » Fixed

Now I understand.

Committed. Thanks for the patch.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.