See http://drupal.org/node/60756#comment-139168.
Happens all the time, there must be hundreds of unnecessary issue comments, issue updates and email notifications.

That's one small step for Forms API, one giant leap for usability.

Comments

dww’s picture

dww
we/he/they
commented

sorry, i don't fully understand what you want, why you want it, and how that comment you referenced (where you forgot to attach a patch) is relevant. ;)

can you please explain what this checkbox does, what it means, and what problem it solves or need it fullfills?

once i understand, i'll be more able to work this in...

of course, i'm not really doing anything these days except the new release system (http://drupal.org/node/77562), so don't expect this to happen immediately.

thanks,
-derek

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

Hi Derek, thanks for replying. Well, it looks quite unnecessary to implement this, but if you look at all project issues on Drupal.org as a whole then you will see that it would be a very beneficial feature to have regarding workflow and usability.

The point is, you're creating hundreds of patches for issues. Everytime you're creating one you have to write a summary what your patch does, what it changes and so on. I think there is no developer yet who did not miss to attach the actual patch once after writing a issue comment. Each time this happens, a unnecessary new issue comment is created, the issue is updated and there are even email notifications sent to subscribers of that particular issue.

So I'm proposing a simple checkbox at the very beginning of the issue comment form that labels "I will add a patch later". If this option is enabled by a user, then the new issue comment will not be submitted until there is a patch attached to the comment. If the option is enabled and there is no patch attached, the user will receive a message "You've chosen to upload a patch. Did you forget this?".

This could be simply done by adding a checkbox to project_issue_form() and adding a condition to project_issue_node_form_validate().

Don't put me down for this request. It's just a simple proposal to avoid user mistakes - this one happens very often.

hunmonk’s picture

hunmonk commented
Status: Active » Closed (won't fix)

i don't like this approach -- it adds another step for people to remember, when the problem is they're forgetting in the first place. i'd rather see this kind of issue worked out in a more comprehensive redesign, rather than slapping something on top of our current UI.

joachim’s picture

joachim commented

Surely the 'will add a patch' is the change in status from 'active' to 'needs review'?
Though sometimes people attach the patch and forget to change that....